----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11351/#review21338 -----------------------------------------------------------
third_party/libprocess/src/process.cpp <https://reviews.apache.org/r/11351/#comment44244> This comment doesn't seem to accurately describe the race condition, even with this fix, we will _open_ the gate before another thread _approaches_ it. Previously s/will/sometimes/. Were you specifically referring to the fact that now we will only _approach_ in ProcessManager::wait when the gate is opened? third_party/libprocess/src/process.cpp <https://reviews.apache.org/r/11351/#comment44245> We pulled gate out of the gates map but we don't erase from the map here. Is that because ProcessManager::cleanup performs an erase()? - Ben Mahler On May 23, 2013, 8:46 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11351/ > ----------------------------------------------------------- > > (Updated May 23, 2013, 8:46 p.m.) > > > Review request for mesos and Vinod Kone. > > > Description > ------- > > See summary. > > > Diffs > ----- > > third_party/libprocess/src/process.cpp > edcb684332590f0277bafb2d69de68413fc82828 > > Diff: https://reviews.apache.org/r/11351/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
