----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11798/#review21717 -----------------------------------------------------------
Ship it! src/tests/status_update_manager_tests.cpp <https://reviews.apache.org/r/11798/#comment44882> Why not pause the clock before ExecutorDriver::sendStatusUpdate? Or better, just before the FUTURE_DISPATCH for Slave::_statusUpdate? src/tests/status_update_manager_tests.cpp <https://reviews.apache.org/r/11798/#comment44883> Please move '.Times(...' to next line. - Benjamin Hindman On June 11, 2013, 5:48 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11798/ > ----------------------------------------------------------- > > (Updated June 11, 2013, 5:48 a.m.) > > > Review request for mesos. > > > Description > ------- > > See summary. > > > This addresses bug MESOS-502. > https://issues.apache.org/jira/browse/MESOS-502 > > > Diffs > ----- > > src/slave/slave.cpp b5b7e0e44b3aced60ba2e800e05a7f9c0c8f6e5e > src/tests/status_update_manager_tests.cpp > 61ccfcc8165337d02af5641884beee45a2aaa065 > > Diff: https://reviews.apache.org/r/11798/diff/ > > > Testing > ------- > > make check > > sudo GLOG_v=1 ./bin/mesos-tests.sh > --gtest_filter="*DuplicateTerminalUpdates*" --verbose --gtest_repeat=1000 > --gtest_break_on_failure > > > Thanks, > > Vinod Kone > >
