----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11205/#review21724 -----------------------------------------------------------
Ship it! src/tests/allocator_tests.cpp <https://reviews.apache.org/r/11205/#comment44893> Please keep the newline here. src/tests/allocator_tests.cpp <https://reviews.apache.org/r/11205/#comment44894> Please keep the newline here as well, thanks! - Benjamin Hindman On June 5, 2013, 9:07 p.m., Thomas Marshall wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11205/ > ----------------------------------------------------------- > > (Updated June 5, 2013, 9:07 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Description > ------- > > Refactors HierarchicalAllocatorProcess to use role instead of user. Also adds > role as a field in FrameworkInfo, and updated DRFAllocatorTest appropriately. > > > Diffs > ----- > > include/mesos/mesos.proto ece6559 > src/master/hierarchical_allocator_process.hpp 1048a28 > src/tests/allocator_tests.cpp 32f0a90 > > Diff: https://reviews.apache.org/r/11205/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Thomas Marshall > >
