----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11119/#review21749 -----------------------------------------------------------
hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java <https://reviews.apache.org/r/11119/#comment44939> Are you missing a diff here? I don't see this resolved per my earlier comment? hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java <https://reviews.apache.org/r/11119/#comment44938> How is this possible? hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java <https://reviews.apache.org/r/11119/#comment44937> This is going to print the same job id multiple times as we add tasks of the same job. Can you revert this? - Vinod Kone On June 11, 2013, 9:42 p.m., Brenden Matthews wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11119/ > ----------------------------------------------------------- > > (Updated June 11, 2013, 9:42 p.m.) > > > Review request for mesos. > > > Description > ------- > > Don't prematurely kill TaskTrackers. > > We assign the JobID to the internal Mesos tracker (for the TaskTracker) > rather than the TaskID. > > In the case where a TaskTracker has only map tasks assigned to it and > they have all completed, we mustn't terminate the tracker until the > entire job has finished, including the map tasks. > > Review: https://reviews.apache.org/r/11119 > > > Diffs > ----- > > hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java > afe401f5265e3d9494af7eace42eec45943184a3 > > Diff: https://reviews.apache.org/r/11119/diff/ > > > Testing > ------- > > Used in production at airbnb. > > make -j10 check && cd hadoop && make hadoop-2.0.0-mr1-cdh4.2.1 && make > hadoop-0.20.205.0 && make hadoop-0.20.2-cdh3u3 > > > Thanks, > > Brenden Matthews > >
