> On June 11, 2013, 10:53 p.m., Vinod Kone wrote: > > hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java, line 751 > > <https://reviews.apache.org/r/11604/diff/3/?file=303687#file303687line751> > > > > why did you have to do this? > > Brenden Matthews wrote: > If the task ends before the timer fires, it should be cancelled to make > sure it doesn't execute.
Oh, I see. `mesosTrackers' is a hash map of <Host, Tracker> where `tracker' in this context is the host, not the actual tracker object. - Brenden ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11604/#review21761 ----------------------------------------------------------- On June 11, 2013, 9 p.m., Brenden Matthews wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11604/ > ----------------------------------------------------------- > > (Updated June 11, 2013, 9 p.m.) > > > Review request for mesos. > > > Description > ------- > > Stop tracker timer when we terminate tasks. > > Review: https://reviews.apache.org/r/11604 > > > Diffs > ----- > > hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java > afe401f5265e3d9494af7eace42eec45943184a3 > > Diff: https://reviews.apache.org/r/11604/diff/ > > > Testing > ------- > > Used in production at airbnb. > > make -j10 check && cd hadoop && make hadoop-2.0.0-mr1-cdh4.2.1 && make > hadoop-0.20.205.0 && make hadoop-0.20.2-cdh3u3 > > > Thanks, > > Brenden Matthews > >
