----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11853/ -----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone. Description ------- killtree.sh has become a source of annoyance over time, the new os::killtree utility is written in C++ and uses a more robust killing technique. Also, killtree.sh on OSX had an issue with session ids from ps. Diffs ----- bin/mesos-build-env.sh.in 31bccad3fab133dcb67670a2727b8ce433f62f70 src/Makefile.am e67b342e7a63696adc8e8b74ce569d9a6fb415a5 src/common/process_utils.hpp a04f4a203cea707c6c48e46f1303baf812a6c57c src/launcher/executor.cpp 1a6725a8098d21bb813d66649257263b5e96136e src/scripts/killtree.sh c42665476834f14f41bdcb2609bcc1baea44100c src/slave/process_isolator.cpp b54bf7e81803863ea4eae26e43ceddda39fcf798 src/tests/environment.cpp 24227c531b2a750340343038228d558b65469bfc src/tests/killtree_tests.cpp 753c5c07e0e17aa78646027b7b04419044cf20a2 src/tests/mesos.cpp 6dbf7f3dcd484ea0092f5690fb12ef350477f19c src/tests/slave_recovery_tests.cpp 0315c524b2552e6a662fda7dfe58efa8c52f90de Diff: https://reviews.apache.org/r/11853/diff/ Testing ------- make check on OSX and linux. Thanks, Ben Mahler
