----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11210/#review21820 -----------------------------------------------------------
Ship it! src/master/http.cpp <https://reviews.apache.org/r/11210/#comment45070> Once you add the ability to "dedicate" resources to a framework we should update this to be an object with two fields called 'dedicated' and 'allocated' (i.e., { "reserved": ..., "allocated": ... }). Also, s/dedicated/reserved/ sounds much better to me (and is more inline with prior work in cluster management). src/master/master.hpp <https://reviews.apache.org/r/11210/#comment45023> This fits on one line. - Benjamin Hindman On June 5, 2013, 9:34 p.m., Thomas Marshall wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11210/ > ----------------------------------------------------------- > > (Updated June 5, 2013, 9:34 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Description > ------- > > Adds two http endpoints: one takes a few parameters and allows for adding, > removing, and updating roles. The other returns the current roles as json. > > > Diffs > ----- > > src/master/http.hpp 9eb0a31 > src/master/http.cpp 7e105a4 > src/master/master.hpp 8e7b74c > src/master/master.cpp a2e4b90 > > Diff: https://reviews.apache.org/r/11210/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Thomas Marshall > >
