> On June 4, 2013, 1:23 a.m., Ben Mahler wrote: > > src/common/values.cpp, line 51 > > <https://reviews.apache.org/r/11487/diff/1/?file=300047#file300047line51> > > > > What was the motivation for this one? > > Brenden Matthews wrote: > When I passed an argument to Mesos like this so: > > --resources='cpu:99;mem:99;' > > It was exploding on the `'`. I ended up wrapping the entire command > arguments in quotes anyway, so I didn't need the extra quotes around the > resources arg.
In that case, sounds like we should discard this review? Alternatively "--resources=cpu:99;mem:99" should work? - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11487/#review21399 ----------------------------------------------------------- On June 11, 2013, 7:28 p.m., Brenden Matthews wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11487/ > ----------------------------------------------------------- > > (Updated June 11, 2013, 7:28 p.m.) > > > Review request for mesos. > > > Description > ------- > > Strip spaces and quotes --resources arg. > > Review: https://reviews.apache.org/r/11487 > > > Diffs > ----- > > src/common/values.cpp 36e11d11b5fa26b0bdce17fbfa4f7538db95e27c > > Diff: https://reviews.apache.org/r/11487/diff/ > > > Testing > ------- > > Used in production at airbnb. > > make -j10 check && cd hadoop && make hadoop-2.0.0-mr1-cdh4.2.1 && make > hadoop-0.20.205.0 && make hadoop-0.20.2-cdh3u3 > > > Thanks, > > Brenden Matthews > >
