----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11131/#review21885 -----------------------------------------------------------
src/linux/cgroups.cpp <https://reviews.apache.org/r/11131/#comment45178> Can you update this to do the following sequence? stop -> kill -> continue -> empty -> freeze -> kill -> thaw -> empty where stop/continue send SIGSTOP/SIGCONT You'll want to split up the two sequences: 1. stop -> kill -> continue -> empty 2. freeze -> kill -> thaw -> empty kill can take an 'int signal' so that you don't have to create additional functions for stop/continue. The second chain should only be executed when the first chain does not succeed. The easiest way to do this might be to create a "killed" function that serves as an intermediate version of "finished". Does this all make sense? - Ben Mahler On June 11, 2013, 9:45 p.m., Brenden Matthews wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11131/ > ----------------------------------------------------------- > > (Updated June 11, 2013, 9:45 p.m.) > > > Review request for mesos. > > > Description > ------- > > For cgroups killTasks(): kill, freeze, kill, thaw. > > Review: https://reviews.apache.org/r/11131 > > > Diffs > ----- > > src/linux/cgroups.cpp 8d94fe63610c4c7a48f92d260fcd526b7a83942e > > Diff: https://reviews.apache.org/r/11131/diff/ > > > Testing > ------- > > Used in production at airbnb. > > make -j10 check && cd hadoop && make hadoop-2.0.0-mr1-cdh4.2.1 && make > hadoop-0.20.205.0 && make hadoop-0.20.2-cdh3u3 > > > Thanks, > > Brenden Matthews > >
