----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11891/#review21946 -----------------------------------------------------------
Ship it! Thanks much Charles! src/deploy/mesos-daemon.sh.in <https://reviews.apache.org/r/11891/#comment45247> I'd prefer to do this after 'shift' since the shift is associated with 'PROGRAM=${1}' ... any reason not to do it that way? I also like "configuring" right before we execute ${PROGRAM}. src/deploy/mesos-slave-env.sh.template <https://reviews.apache.org/r/11891/#comment45245> s/master@// src/deploy/mesos-slave-env.sh.template <https://reviews.apache.org/r/11891/#comment45246> s/zook/ZooK/ and s/maseters/masters/ src/deploy/mesos-slave-env.sh.template <https://reviews.apache.org/r/11891/#comment45244> s/master@// - Benjamin Hindman On June 15, 2013, 5:29 a.m., Charles Reiss wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11891/ > ----------------------------------------------------------- > > (Updated June 15, 2013, 5:29 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Description > ------- > > This modifies the deploy scripts to work now that --conf is no longer > supported. Instead, the deploy scripts source mesos-master-env.sh and > mesos-slave-env.sh files to pass environment variables to the masters and > slaves. > > > This addresses bug MESOS-490. > https://issues.apache.org/jira/browse/MESOS-490 > > > Diffs > ----- > > src/Makefile.am 23733b583df1addb29c5ba865a87c73923941804 > src/conf/mesos.conf.template 02da4476c581893b1ed777012dd5157d70868b96 > src/deploy/mesos-daemon.sh.in b89f72d5ab91a8e5fb9085628e2ca0bb79514fdf > src/deploy/mesos-deploy-env.sh.template > afc6197d49c1a88badc2be9edad62684f98829a3 > src/deploy/mesos-master-env.sh.template PRE-CREATION > src/deploy/mesos-slave-env.sh.template PRE-CREATION > > Diff: https://reviews.apache.org/r/11891/diff/ > > > Testing > ------- > > > Thanks, > > Charles Reiss > >
