----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11094/#review21948 -----------------------------------------------------------
Ship it! Really nice cleanup! src/slave/process_isolator.cpp <https://reviews.apache.org/r/11094/#comment45258> s/status/process/ ? src/slave/process_isolator.cpp <https://reviews.apache.org/r/11094/#comment45259> s/status/process/ ? src/tests/environment.cpp <https://reviews.apache.org/r/11094/#comment45260> ... because ... - Benjamin Hindman On June 11, 2013, 7:37 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11094/ > ----------------------------------------------------------- > > (Updated June 11, 2013, 7:37 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > Old review: > https://reviews.apache.org/r/10899/ > > > This addresses bug MESOS-370. > https://issues.apache.org/jira/browse/MESOS-370 > > > Diffs > ----- > > src/slave/process_isolator.cpp b54bf7e81803863ea4eae26e43ceddda39fcf798 > src/tests/environment.cpp 24227c531b2a750340343038228d558b65469bfc > src/tests/isolator_tests.cpp 7013fa290e2bd0666c3576e23476869f155c072c > > Diff: https://reviews.apache.org/r/11094/diff/ > > > Testing > ------- > > Make check on Linux and OSX. > > OSX requires root permissions to get all of the child process information. > > > Thanks, > > Ben Mahler > >
