----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11723/#review21828 -----------------------------------------------------------
src/common/resources.hpp <https://reviews.apache.org/r/11723/#comment45357> Any reason not to use 'isAllocatable'? src/common/resources.hpp <https://reviews.apache.org/r/11723/#comment45095> return resource.scalar().value() == 0; (But you should really use 'isAllocatable'.) src/common/resources.hpp <https://reviews.apache.org/r/11723/#comment45096> return resource.ranges().range_size() == 0; src/common/resources.hpp <https://reviews.apache.org/r/11723/#comment45097> return resource.set().item_size() == 0; - Benjamin Hindman On June 12, 2013, 11:39 p.m., Thomas Marshall wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11723/ > ----------------------------------------------------------- > > (Updated June 12, 2013, 11:39 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Description > ------- > > There's a bug in the Resource <= operator where for example something like > "{cpus:1, mem:0} <= {cpus:2}" would return false, because it considers the 0 > mem on the right side to be greater than the nonexistent mem on the left side. > > > This addresses bug MESOS-505. > https://issues.apache.org/jira/browse/MESOS-505 > > > Diffs > ----- > > src/common/resources.hpp 42dfb6a > > Diff: https://reviews.apache.org/r/11723/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Thomas Marshall > >
