----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11724/#review22107 -----------------------------------------------------------
src/master/hierarchical_allocator_process.hpp <https://reviews.apache.org/r/11724/#comment45499> Why are you initializing this to empty resources here? src/master/hierarchical_allocator_process.hpp <https://reviews.apache.org/r/11724/#comment45500> s/r/role/ src/master/hierarchical_allocator_process.hpp <https://reviews.apache.org/r/11724/#comment45502> i'm confused, when can used[role] > dedications[role]? src/master/hierarchical_allocator_process.hpp <https://reviews.apache.org/r/11724/#comment45501> kinda ironic that you are calling this 'dedicated' while the function is named as undedicatedAvailable. src/master/hierarchical_allocator_process.hpp <https://reviews.apache.org/r/11724/#comment45503> when can this be false? src/master/hierarchical_allocator_process.hpp <https://reviews.apache.org/r/11724/#comment45504> ditto src/master/hierarchical_allocator_process.hpp <https://reviews.apache.org/r/11724/#comment45505> why did you remove the if check? - Vinod Kone On June 12, 2013, 11:39 p.m., Thomas Marshall wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11724/ > ----------------------------------------------------------- > > (Updated June 12, 2013, 11:39 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Description > ------- > > This patch adds functions to the Slave struct in HierarchicalAllocatorProcess > to do resource allocation relative to roles and to statically enforce > resources that have been specified to be dedicated. > > > This addresses bug MESOS-505. > https://issues.apache.org/jira/browse/MESOS-505 > > > Diffs > ----- > > src/master/hierarchical_allocator_process.hpp 1048a28 > > Diff: https://reviews.apache.org/r/11724/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Thomas Marshall > >
