> On June 18, 2013, 6:13 a.m., Vinod Kone wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, lines 1074-1076 > > <https://reviews.apache.org/r/11849/diff/1-2/?file=304305#file304305line1074> > > > > I think more comments are needed for how this filtering happens. for > > eg: is it OR or AND? looking at the code it looks like OR.
My mistake, I've cleaned this function up as it should have been an AND. > On June 18, 2013, 6:13 a.m., Vinod Kone wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, line 1080 > > <https://reviews.apache.org/r/11849/diff/1-2/?file=304305#file304305line1080> > > > > why else if? > > > > Also, why not <= 0? from looking at the later code, it is not like you > > are trying to preserve the getpgid() or getpsid() semantics when > > group/session = 0 anyway? Ok great, now this behaves similarly to getpgid and getsid for an input of 0. Thanks for bringing this up! - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11849/#review22046 ----------------------------------------------------------- On June 18, 2013, 4:42 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11849/ > ----------------------------------------------------------- > > (Updated June 18, 2013, 4:42 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > For how killtree will be used, see the killtree.sh script in mesos. > > This version is actually more robust than killtree.sh, as it first stops the > entire tree, _then_ issues the signal. > Currently, killtree.sh stops, signals, and continues each process in > isolation. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/Makefile.am > 2b7ee9c099a28dc5e482d7609e6307f2b6398e8b > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 1b3fb47d7567b5467fef2a2bb15d5c4a2ea42aa5 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/killtree.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > 73b2336e93d6e5aac97e2c18e8e36c258c56a420 > > Diff: https://reviews.apache.org/r/11849/diff/ > > > Testing > ------- > > Added a test, however this test can be _significantly_ cleaned up were we to > create an abstraction for generating process trees! > > > Thanks, > > Ben Mahler > >
