----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11100/#review22201 -----------------------------------------------------------
src/slave/constants.cpp <https://reviews.apache.org/r/11100/#comment45622> Ok, so 10 per second maximum. Let's say we run 4 tasks per minute, that have 50 files / directories to remove. That's 200/minute -> 3.33 files / minute. Seems like we might need to implement a strategy for handling a growing queue size of removals (by having a dynamic interval), can you add a TODO signaling this potential issue? src/slave/incinerator.hpp <https://reviews.apache.org/r/11100/#comment45623> I/O src/slave/incinerator.hpp <https://reviews.apache.org/r/11100/#comment45625> Incinerator is nice, but how about something like: "GarbageDisposal" // The method could be named 'dispose(path)'. I think this is more intuitive, thoughts guys? I'm ok with Incinerator but I think at first glance it won't be obvious what functionality it provides. - Ben Mahler On June 20, 2013, 10 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11100/ > ----------------------------------------------------------- > > (Updated June 20, 2013, 10 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > The purpose of the incinerator is to move items to trash and empty trash in > rate-limited manner. It is designed to work across slave restarts. > > > Diffs > ----- > > src/Makefile.am 933743593d8de2fcc412d2f771a4cbc1e6fd2884 > src/slave/constants.hpp 901fdf220a902de9241511393530eb19fdfc3244 > src/slave/constants.cpp e8d16ca3307249a8b49720eaf8dcb0e7555fca7a > src/slave/incinerator.hpp PRE-CREATION > src/slave/incinerator.cpp PRE-CREATION > src/tests/gc_tests.cpp 174580086370f61be369f7a212d62531e87e6f01 > > Diff: https://reviews.apache.org/r/11100/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
