> On June 21, 2013, 11:50 p.m., Vinod Kone wrote: > > src/master/master.cpp, lines 1986-1989 > > <https://reviews.apache.org/r/12044/diff/1/?file=310419#file310419line1986> > > > > This is awkwardly placed. Why not print right after > > if (framework != NULL) ? > > > > Also, you could do > > > > LOG(INFO) << "Sending status update " << update > > << " due to removal of slave " << slave->id > > << " ( " << slave->info.hostname() << ")"; > > Vinod Kone wrote: > Also, while you are at it, mind cleaning this up by using > protobuf::createStatusUpdate()?
Fixed although I kept the log line after the update creation, as it now prints the update directly. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12044/#review22288 ----------------------------------------------------------- On June 21, 2013, 11:40 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12044/ > ----------------------------------------------------------- > > (Updated June 21, 2013, 11:40 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > See bug description. > > > This addresses bug MESOS-503. > https://issues.apache.org/jira/browse/MESOS-503 > > > Diffs > ----- > > src/master/master.cpp 60c6d4f88f8024796c5e495d7cc6ddde2b754887 > > Diff: https://reviews.apache.org/r/12044/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
