----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12033/#review22370 -----------------------------------------------------------
Ship it! jenkins/src/main/java/org/jenkinsci/plugins/mesos/JenkinsScheduler.java <https://reviews.apache.org/r/12033/#comment45889> Let's add some log messages to these stubs so that if folks start running this we can debug more easily. jenkins/src/main/java/org/jenkinsci/plugins/mesos/JenkinsScheduler.java <https://reviews.apache.org/r/12033/#comment45888> bad indent? jenkins/src/main/java/org/jenkinsci/plugins/mesos/JenkinsScheduler.java <https://reviews.apache.org/r/12033/#comment45890> Ditto for logging. jenkins/src/main/java/org/jenkinsci/plugins/mesos/JenkinsScheduler.java <https://reviews.apache.org/r/12033/#comment45891> ditto for logging jenkins/src/main/java/org/jenkinsci/plugins/mesos/MesosCloud.java <https://reviews.apache.org/r/12033/#comment45892> Can you fix the comment wrapping here? jenkins/src/main/java/org/jenkinsci/plugins/mesos/MesosCloud.java <https://reviews.apache.org/r/12033/#comment45893> s/page/page./ jenkins/src/main/java/org/jenkinsci/plugins/mesos/MesosComputerLauncher.java <https://reviews.apache.org/r/12033/#comment45894> kill newline jenkins/src/main/java/org/jenkinsci/plugins/mesos/MesosComputerLauncher.java <https://reviews.apache.org/r/12033/#comment45895> these are @Overrides right? jenkins/src/main/java/org/jenkinsci/plugins/mesos/MesosComputerLauncher.java <https://reviews.apache.org/r/12033/#comment45896> s/till/until/ jenkins/src/main/java/org/jenkinsci/plugins/mesos/MesosComputerLauncher.java <https://reviews.apache.org/r/12033/#comment45897> s/jenkins/Jenkins/ jenkins/src/main/java/org/jenkinsci/plugins/mesos/MesosRetentionStrategy.java <https://reviews.apache.org/r/12033/#comment45898> kill newline - Ben Mahler On June 25, 2013, 1:47 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12033/ > ----------------------------------------------------------- > > (Updated June 25, 2013, 1:47 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Jiang Yan Xu. > > > Bugs: MESOS-506 > https://issues.apache.org/jira/browse/MESOS-506 > > > Repository: mesos > > > Description > ------- > > This is the initial commit of the Jenkins scheduler. Basically all the code > and proper pom. > > NOTE: Not yet integrated into our build tool chain. > > > Diffs > ----- > > jenkins/pom.xml PRE-CREATION > jenkins/src/main/java/org/jenkinsci/plugins/mesos/JenkinsScheduler.java > PRE-CREATION > jenkins/src/main/java/org/jenkinsci/plugins/mesos/Mesos.java PRE-CREATION > jenkins/src/main/java/org/jenkinsci/plugins/mesos/MesosCloud.java > PRE-CREATION > jenkins/src/main/java/org/jenkinsci/plugins/mesos/MesosComputer.java > PRE-CREATION > > jenkins/src/main/java/org/jenkinsci/plugins/mesos/MesosComputerLauncher.java > PRE-CREATION > > jenkins/src/main/java/org/jenkinsci/plugins/mesos/MesosRetentionStrategy.java > PRE-CREATION > jenkins/src/main/java/org/jenkinsci/plugins/mesos/MesosSlave.java > PRE-CREATION > jenkins/src/main/java/org/jenkinsci/plugins/mesos/TaskTemplate.java > PRE-CREATION > jenkins/src/main/resources/index.jelly PRE-CREATION > > jenkins/src/main/resources/org/jenkinsci/plugins/mesos/MesosCloud/computerSet.jelly > PRE-CREATION > > jenkins/src/main/resources/org/jenkinsci/plugins/mesos/MesosCloud/config.jelly > PRE-CREATION > > jenkins/src/main/resources/org/jenkinsci/plugins/mesos/MesosCloud/help-master.html > PRE-CREATION > > jenkins/src/main/resources/org/jenkinsci/plugins/mesos/MesosSlave/configure-entries.jelly > PRE-CREATION > > jenkins/src/main/resources/org/jenkinsci/plugins/mesos/TaskTemplate/config.jelly > PRE-CREATION > > Diff: https://reviews.apache.org/r/12033/diff/ > > > Testing > ------- > > MESOS_NATIVE_LIBRARY=/Users/vinod/workspace/apache/mesos/build/src/.libs/libmesos.dylib > JAVA_HOME=/Library/Java/JavaVirtualMachines/jdk1.7.0_07.jdk/Contents/Home > mvn hpi:run > > > Thanks, > > Vinod Kone > >
