----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12118/ -----------------------------------------------------------
Review request for mesos, Ben Mahler and Vinod Kone. Repository: mesos Description ------- We can't put flags that are not shared in mesos-build-env.sh. Thus, I don't see much value in having mesos-build-env.sh.in for only the "shared" flags since there are very few of these. Furthermore, I like the simplification of just looking in mesos-slave.sh.in or mesos-master.sh.in, etc. to see exactly what flags are getting set. Diffs ----- bin/mesos-build-env.sh.in f2bbe42997007adc4b342991210067218b807d09 bin/mesos-local.sh.in 2ac67898cd99d56039dbb5d2c9876259ec7b1dd8 bin/mesos-master.sh.in fa9f139ba7678b24f366813ccea00af8dbf33000 bin/mesos-slave.sh.in 0384bcb8151bdfea4b99ebee8116172f27a8ae93 bin/mesos-tests.sh.in 8d19556cefd55175d20f69f30efc2e2d884d5460 configure.ac fbe22e5772502ef3d9bea7b58b323881a51934ab Diff: https://reviews.apache.org/r/12118/diff/ Testing ------- ./bin/mesos-master.sh Thanks, Benjamin Hindman
