-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12145/
-----------------------------------------------------------
(Updated June 28, 2013, 6:30 a.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
Changes
-------
BenM's comments.
Summary (updated)
-----------------
Fixed a misplaced assertion that in rare occasions caused test failures.
Bugs: MESOS-534
https://issues.apache.org/jira/browse/MESOS-534
Repository: mesos
Description
-------
- Reaper could have reaped the pid at the time of the assertion.
- Issue: https://issues.apache.org/jira/browse/MESOS-534
Diffs (updated)
-----
src/tests/reaper_tests.cpp c9818ac
Diff: https://reviews.apache.org/r/12145/diff/
Testing
-------
- ./bin/mesos-tests.sh --gtest_filter="ReaperTest.TerminatedChildProcess"
--gtest_repeat=1000 --gtest_break_on_failure Passed.
- However, ./bin/mesos-tests.sh --gtest_filter="ReaperTest.NonChildProcess"
--gtest_repeat=1000 --gtest_break_on_failure is still flaky:
[ RUN ] ReaperTest.NonChildProcess
Detaching after fork from child process 25627.
libprocess: reaper(788)@10.35.255.108:45752 terminating due to
basic_filebuf::underflow error reading the file
- Seems to be related to this though:
https://issues.apache.org/jira/browse/MESOS-434
Thanks,
Jiang Yan Xu
