----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12215/#review22631 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp <https://reviews.apache.org/r/12215/#comment46319> Would it make more sense to just return an error if the times are invalid? With the current logic it looks the callers of process() need to know that a Process could have invalid (-1) utime and stime and deal with it accordingly. - Vinod Kone On July 1, 2013, 10:45 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12215/ > ----------------------------------------------------------- > > (Updated July 1, 2013, 10:45 p.m.) > > > Review request for mesos, Benjamin Hindman, Brenden Matthews, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > This was reported by Brenden Matthews on the mailing list. It appears that on > some Linux systems the utime / stime values coming from /proc are corrupt. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp > ef6c6c8f7839baaddcfd20249f2dbd25a7c3d25a > > Diff: https://reviews.apache.org/r/12215/diff/ > > > Testing > ------- > > make check > > Also ran the isolator tests with 100 iterations. > > > Thanks, > > Ben Mahler > >
