----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12123/#review22676 -----------------------------------------------------------
Can you confirm this fixes MESOS-417? If so, great! And be sure to link the ticket in this review. I wish there was a cleaner way to uniquely identify the framework "run" we care about. There are a few ways that we may want to consider in the long term if this continues to get messier. We could add a run identifier to framework information. Alternatively, we could merge the completedFramework information with the re-registration of the framework. Thoughts for later. src/webui/master/static/controllers.js <https://reviews.apache.org/r/12123/#comment46357> Can you adjust the comment to reflect the fact that we're merging the active and completed runs of the framework? Note that the framework can only be present once in frameworks, but multiple times in completed_frameworks (depending on the number of failovers). Also s/framework/frameworkRuns/ to be more clear. - Ben Mahler On June 26, 2013, 9:55 p.m., Brenden Matthews wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12123/ > ----------------------------------------------------------- > > (Updated June 26, 2013, 9:55 p.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > ------- > > WebUI fix: list all framework tasks. > > > Diffs > ----- > > src/webui/master/static/controllers.js > f9d7c978fe4cf6d2fbb4d45990b277e44485f0cd > > Diff: https://reviews.apache.org/r/12123/diff/ > > > Testing > ------- > > Used in production at Airbnb. > > Tested by using. > > > Thanks, > > Brenden Matthews > >
