I post a review now. https://reviews.apache.org/r/12262/
Last time I send a patch by mail Ben said he can not see the patch file either. :( But I can see the file in my mail box... Guodong On Thu, Jul 4, 2013 at 1:04 PM, Vinod Kone <[email protected]> wrote: > did you forget to attach the patch? can you just a send review via apache > review board? https://reviews.apache.org > > > On Wed, Jul 3, 2013 at 8:06 PM, 王国栋 <[email protected]> wrote: > > > Hi Vinod. > > > > My patch is attached. Please check. > > > > It is quite easy, Just copy the the patch of cdh3u3 :) > > > > Guodong > > > > > > On Wed, Jul 3, 2013 at 4:04 PM, 王国栋 <[email protected]> wrote: > > > >> of course not. i will attach the patch later. > >> > >> Guodong > >> > >> > >> On Wed, Jul 3, 2013 at 12:05 PM, Vinod Kone <[email protected]> > wrote: > >> > >>> We would be happy to upgrade the hadoop port to cdh3u5. Do you mind > >>> sending > >>> us a patch? > >>> > >>> > >>> On Tue, Jul 2, 2013 at 8:13 PM, 王国栋 <[email protected]> wrote: > >>> > >>> > Hi guys, > >>> > > >>> > I have tested hadoop on Mesos for a few weeks. Our hadoop version is > >>> > cdh3u5. I have used the patch for cdh3u3 in my test. > >>> > > >>> > I think this path is also works well for cdh3u5, so , can you add one > >>> more > >>> > target "hadoop-0.20.2-cdh3u5" in the Make file which may be very > >>> similar to > >>> > hadoop-0.20.2-cdh3u3. Just download hadoop-0.20.2-cdh3u5 version and > >>> apply > >>> > the patch. > >>> > > >>> > I think this will be more convenient. :) > >>> > > >>> > Actually I have made some changes in the makefile, I am also very > glad > >>> to > >>> > post a review, if it is possible. > >>> > > >>> > Thanks. > >>> > > >>> > Guodong > >>> > > >>> > >> > >> > > >
