On Fri, Sep 20, 2013 at 08:49:00PM +0000, Cooper Jr., Franklin wrote: > > > > -----Original Message----- > > From: [email protected] [mailto:meta-arago- > > [email protected]] On Behalf Of Maupin, Chase > > Sent: Friday, September 20, 2013 3:31 PM > > To: Denys Dmytriyenko > > Cc: [email protected] > > Subject: Re: [meta-arago] [PATCH] sourceipk: do not dereference symlinks > > when packaging data to avoid breakage > > > > Will this still package things like the patches applied on top of the > > kernel in the > > kernel sources? > > [Franklin] Good call. Your right it doesn't. I gave it a shot and the > symbolic link remains but of course the link is broken if it is used on a > different machine.
Yeah, I had the same question originally. Unfortunately, you cannot assume there are no broken links in the sources to begin with. And those broken symlinks cannot be dereferenced w/o breaking the entire tar command and hence the build. That is what we discussed couple days ago - kernel now has a broken symlink that kills our sourceipk... Why do patches symlinked and not copied? Can we fix that step instead of doing it in tar command? -- Denys > > On Sep 20, 2013, at 2:00 PM, "Denys Dmytriyenko" <[email protected]> wrote: > > > > > From: Denys Dmytriyenko <[email protected]> > > > > > > Signed-off-by: Denys Dmytriyenko <[email protected]> > > > --- > > > meta-arago-distro/classes/sourceipk.bbclass | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/meta-arago-distro/classes/sourceipk.bbclass b/meta-arago- > > distro/classes/sourceipk.bbclass > > > index 1ea0577..777cb4f 100644 > > > --- a/meta-arago-distro/classes/sourceipk.bbclass > > > +++ b/meta-arago-distro/classes/sourceipk.bbclass > > > @@ -167,7 +167,7 @@ sourceipk_do_create_srcipk() { > > > fi > > > > > > #Write the data tarball > > > - tar -C $tmp_dir --owner=0 --group=0 -chzf > > > $srcipk_dir/data.tar.gz . > > > + tar -C $tmp_dir --owner=0 --group=0 -czf $srcipk_dir/data.tar.gz > > > . > > > > > > # Create the debian-binary file > > > echo "2.0" > $srcipk_dir/debian-binary > > > -- > > > 1.8.3.2 > > > > > > _______________________________________________ > > > meta-arago mailing list > > > [email protected] > > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago > > _______________________________________________ > > meta-arago mailing list > > [email protected] > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago > _______________________________________________ > meta-arago mailing list > [email protected] > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago _______________________________________________ meta-arago mailing list [email protected] http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
