On Fri, Sep 20, 2013 at 04:55:07PM -0400, Cooper Jr., Franklin wrote: > > > > -----Original Message----- > > From: Dmytriyenko, Denys > > Sent: Friday, September 20, 2013 3:19 PM > > To: Cooper Jr., Franklin > > Cc: [email protected] > > Subject: Re: [meta-arago] [PATCH 1/2] tisdk-rootfs-base-image: Rename base > > file system image > > > > On Fri, Sep 20, 2013 at 03:38:06PM -0400, Cooper Jr., Franklin wrote: > > > > > > > > > > -----Original Message----- > > > > From: Dmytriyenko, Denys > > > > Sent: Friday, September 20, 2013 2:31 PM > > > > To: Cooper Jr., Franklin > > > > Cc: [email protected] > > > > Subject: Re: [meta-arago] [PATCH 1/2] tisdk-rootfs-base-image: > > > > Rename base file system image > > > > > > > > On Tue, Sep 17, 2013 at 04:05:10PM -0400, Cooper Jr., Franklin wrote: > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > From: Dmytriyenko, Denys > > > > > > Sent: Tuesday, September 17, 2013 2:52 PM > > > > > > To: Cooper Jr., Franklin; [email protected] > > > > > > Subject: RE: [meta-arago] [PATCH 1/2] tisdk-rootfs-base-image: > > > > > > Rename base file system image > > > > > > > > > > > > What was the initial reason to start naming rootfs images with > > > > > > tisdk-rootfs- prefix? I remember it was something forced by the SDK > > setup... > > > > > [Franklin] > > > > > This was before my time so I am not sure what the original reasoning > > > > > was. > > > > > > > > > > I do assume there might be instances where some script somewhere > > > > > will need to be updated if it refers to the full image as > > > > > "tisdk-rootfs*" > > > > > > > > So, I located the change I was talking about: > > > > http://arago-project.org/git/?p=meta- > > > > arago.git;a=commitdiff;h=91f2be34e301deebbc75c54bbad6a5a27e25bf2c > > > > > > > > The "tisdk-image class had issues" is a rather vague description, so > > > > I'm not sure or don't remember what was the problem that you had to > > > > rename the original arago-tisdk-image into tisdk-rootfs-image... > > > > > > > > > [Franklin] Ah I remember. The TARGET_IMAGES variable is used in two > > > ways in that class. 1 to add a build dependency and 2 to reference the > > > image tarball. So the assumption was that the recipe/package name was > > > the same as the IMAGE_BASENAME. So the recipe and IMAGE_BASENAME > > must > > > match. Otherwise the image would be built but the class wouldn't know > > > what tarball to look for. > > > > Ah, OK, this is not exactly what I was looking for. Tracing even further > > back > > shows that you added the recipe to have IMAGE_BASENAME = "tisdk-rootfs": > > > > http://arago-project.org/git/?p=meta- > > arago.git;a=commitdiff;h=f27b1f34aee2c2cbee25a0fb5b21cdb04f16ec4a > > > > Do you remember the reason for that? This image recipe was in Classic arago, > > but there it had the basename matching the recipe name. Wondering why the > > change?
> [Franklin] I think I was simply trying to match the filesystem tarball with > the name used in previous sdks. I am assuming that the SDK backend script > that built the sdk renamed those filesystem files. Looking at Sitara AMSDK > 05.05.01 (last oe-classic based sdk) the two filesystem tarballs were named > base-rootfs-am335x-evm.tar.gz and tisdk-rootfs-am335x-evm.tar.gz. During > that time I was focused on just getting the filesystem working and wanted it > to look like the output from previous sdks. I don't think I had any other > reason. Thanks! Just wanted to check if there was some sort of requirement for that name change. If there is not, then we can look for a better names for full image as well as base image. Should we look into unifying the names for other image recipes? Is tisdk-rootfs- the best base we can think of? -- Denys > > > > > > -----Original Message----- > > > > > > From: [email protected] [mailto:meta-arago- > > > > > > [email protected]] On Behalf Of Cooper Jr., Franklin > > > > > > Sent: Tuesday, September 17, 2013 3:13 PM > > > > > > To: [email protected] > > > > > > Cc: Cooper Jr., Franklin > > > > > > Subject: [meta-arago] [PATCH 1/2] tisdk-rootfs-base-image: Rename > > base > > > > file > > > > > > system image > > > > > > > > > > > > * People are frequently confused by the difference in naming between > > the > > > > > > minimal > > > > > > file system and the larger file system. > > > > > > * Rename the minimal file system to mimic the naming convention of > > > > > > the > > > > larger > > > > > > file system. > > > > > > > > > > > > Signed-off-by: Franklin S. Cooper Jr <[email protected]> > > > > > > --- > > > > > > ...e-tisdk-image.bb => tisdk-rootfs-base-image.bb} | 2 +- > > > > > > 1 files changed, 1 insertions(+), 1 deletions(-) rename > > > > > > meta-arago- > > > > > > distro/recipes-core/images/{arago-base-tisdk-image.bb => > > > > > > tisdk-rootfs- > > > > base- > > > > > > image.bb} (87%) > > > > > > > > > > > > diff --git a/meta-arago-distro/recipes-core/images/arago-base-tisdk- > > > > image.bb > > > > > > b/meta-arago-distro/recipes-core/images/tisdk-rootfs-base-image.bb > > > > > > similarity index 87% > > > > > > rename from meta-arago-distro/recipes-core/images/arago-base-tisdk- > > > > > > image.bb > > > > > > rename to meta-arago-distro/recipes-core/images/tisdk-rootfs-base- > > > > image.bb > > > > > > index 2c0e217..a3a9123 100644 > > > > > > --- > > > > > > a/meta-arago-distro/recipes-core/images/arago-base-tisdk-image.bb > > > > > > +++ b/meta-arago-distro/recipes-core/images/tisdk-rootfs-base- > > image.bb > > > > > > @@ -12,4 +12,4 @@ IMAGE_INSTALL += "\ > > > > > > packagegroup-arago-base-tisdk \ > > > > > > " > > > > > > > > > > > > -export IMAGE_BASENAME = "arago-base-tisdk-image" > > > > > > +export IMAGE_BASENAME = "tisdk-rootfs-base-image" > > > > > > -- > > > > > > 1.7.0.4 > > > > > > > > > > > > _______________________________________________ > > > > > > meta-arago mailing list > > > > > > [email protected] > > > > > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago _______________________________________________ meta-arago mailing list [email protected] http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
