> -----Original Message----- > From: Maupin, Chase > Sent: Thursday, January 30, 2014 4:54 PM > To: Cooper Jr., Franklin; [email protected] > Subject: RE: [meta-arago] [PATCH] ts-calibrate: Always export TSLIB_CALIBFILE > env variable > > >-----Original Message----- > >From: [email protected] [mailto:meta-arago- > >[email protected]] On Behalf Of Cooper Jr., Franklin > >Sent: Thursday, January 30, 2014 6:13 PM > >To: [email protected] > >Cc: Cooper Jr., Franklin > >Subject: [meta-arago] [PATCH] ts-calibrate: Always export > >TSLIB_CALIBFILE env variable > > > >* Previously TSLIB_CALIBFILE env variable was only being exported if > >the mmc > > partition was mounted. > >* Move the export statement outside of the if statement to insure that > >this > > important variable is always exported. > > > >Signed-off-by: Franklin S. Cooper Jr <[email protected]> > >--- > > .../recipes-graphics/tslib/ts-calibrate-init/init | 3 ++- > > .../tslib/ts-calibrate-init_1.0.bb | 2 +- > > 2 files changed, 3 insertions(+), 2 deletions(-) > > > >diff --git a/meta-arago-extras/recipes-graphics/tslib/ts- > >calibrate-init/init b/meta-arago-extras/recipes-graphics/tslib/ts- > >calibrate-init/init > >index 5d5c0aa..ab19da3 100644 > >--- a/meta-arago-extras/recipes-graphics/tslib/ts-calibrate- > >init/init > >+++ b/meta-arago-extras/recipes-graphics/tslib/ts-calibrate- > >init/init > >@@ -31,9 +31,10 @@ mount | grep /media/mmcblk0p1 | grep vfat > > >/dev/null 2>&1 if [ "$?" = "0" ] then > > tsfile=/media/mmcblk0p1/pointercal > >- export TSLIB_CALIBFILE=$tsfile > > fi > > > >+export TSLIB_CALIBFILE=$tsfile > > This is a nice to have but not strictly required right? Because the default > is > /etc/pointercal and you only need to reset this if you are pointing to the SD > card. > Or am I missing something? [Franklin] Your right if tslib by default assumes that file is located at /etc/pointercal but at the time I didn't think that was the case.
After searching some more that is indeed the case: http://manpages.ubuntu.com/manpages/raring/man5/ts.conf.5.html So we can take this patch or leave it. > > >+ > > if [ ! -f $tsfile ] ; then > > echo -n "Calibrating touchscreen (first time only)" > > ts_calibrate > >diff --git a/meta-arago-extras/recipes-graphics/tslib/ts- > >calibrate-init_1.0.bb b/meta-arago-extras/recipes- > >graphics/tslib/ts-calibrate-init_1.0.bb > >index dde5c42..0915941 100644 > >--- a/meta-arago-extras/recipes-graphics/tslib/ts-calibrate- > >init_1.0.bb > >+++ b/meta-arago-extras/recipes-graphics/tslib/ts-calibrate- > >init_1.0.bb > >@@ -6,7 +6,7 @@ RDEPENDS_${PN} += "tslib" > > LICENSE = "GPLv2" > > LIC_FILES_CHKSUM = > >"file://init;beginline=2;endline=11;md5=4b2e3b15f01cf63d2cb7988afd > >cc6c60" > > > >-PR = "r2" > >+PR = "r3" > > > > S = "${WORKDIR}" > > > >-- > >1.7.0.4 > > > >_______________________________________________ > >meta-arago mailing list > >[email protected] > >http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago _______________________________________________ meta-arago mailing list [email protected] http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
