Please see response in-lined. -Best Regards, Aravind
> -----Original Message----- > From: Dmytriyenko, Denys > Sent: Wednesday, February 05, 2014 2:53 PM > To: Aravind Batni > Cc: [email protected] > Subject: Re: [meta-arago] [PATCH v2] ti-csl: new recipe providing CSL for TI- > KeyStone2 devices > > On Wed, Feb 05, 2014 at 01:14:42PM -0500, Aravind Batni wrote: > > -This package provides chip support library interface files > > > > Signed-off-by: Aravind Batni <[email protected]> > > --- > > * grouped SRC_URI and SRCREV together > > * Modified do_install to copy the needed files only instead of copy > everything > > delete unwanted files. > > --- > > --- > > meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb | 22 > ++++++++++++++++++++ > > 1 file changed, 22 insertions(+) > > create mode 100644 meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb > > > > diff --git a/meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb > > b/meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb > > new file mode 100644 > > index 0000000..37f7937 > > --- /dev/null > > +++ b/meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb > > @@ -0,0 +1,22 @@ > > +DESCRIPTION = "TI CSL" > > +LICENSE = "TI BSD" > > +LIC_FILES_CHKSUM = > "file://COPYING.txt;md5=5857833e20836213677fac33f9aded21" > > + > > +COMPATIBLE_MACHINE = "keystone-evm" > > Do you want to relax it to entire "keystone" family, not just EVM? > [Aravind Batni] Yes, we can change it to "keystone" > > > +ALLOW_EMPTY_${PN} = "1" > > + > > +PR = "r0" > > +BRANCH="master" > > +SRC_URI = "git://git.ti.com/keystone-rtos/common-csl- > ip.git;protocol=git;branch=${BRANCH}" > > +# commit ID corresponds to DEV.CSL_KEYSTONE2.02.00.00.17 SRCREV = > > +"f6f90144c14e1ee783c4b893b52e54830be8166e" > > +S = "${WORKDIR}/git" > > + > > +do_install () { > > + cd ${S} > [Aravind Batni] Yes, this can be removed and would be part of next patch submit. > do_install already operates from within ${S}. If you need to control it > further, > you can pass it to find commands below, instead of "." > > Either way it's rather nit-picking, along with SRCREV order... > > [Aravind Batni] "find " needs the relative path from ${S} for CSL while installing to /usr/include. If we provide ${S} instead of ".", find will result in absolute path which will result in in correct installation of CSL files. We will send an updated patch with the updates as mentioned. > > + install -d ${D}${includedir}/ti/csl > > + find . -name "*.h" -type f | xargs -I {} cp --parents {} > ${D}${includedir}/ti/csl > > + find ./src/ip/serdes_sb/V0 -name "*.c" -type f | xargs -I {} cp > > +--parents {} ${D}${includedir}/ti/csl/src/ip/serdes_sb/V0 > > +} > > + > > -- > > 1.7.9.5 > > > > _______________________________________________ > > meta-arago mailing list > > [email protected] > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago _______________________________________________ meta-arago mailing list [email protected] http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
