>-----Original Message----- >From: [email protected] [mailto:meta-arago- >[email protected]] On Behalf Of Nelson, Sam >Sent: Monday, March 03, 2014 6:14 PM >To: [email protected] >Subject: [meta-arago] [PATCH v3 1/2] lksctp-tools: Add recipe for >lksctp tools > >- Copied as is from meta-arago-extras/recipes-bsp/lksctp- >tools/lksctp-tools_1.0.7.bb >- With intention to fix issues to make it work.
This is not clear enough. For one thing you mention copying as is from the same location that you are adding it to so I'm unclear on that. Second, what issues are being fixed, etc? You have a v3 on this but there is no history of the revisions and what has changed in between. Further comments below. > >Signed-off-by: Sam Nelson <[email protected]> >--- > .../recipes-bsp/lksctp-tools/lksctp-tools.inc | 47 >++++++++++++++++++++ > .../recipes-bsp/lksctp-tools/lksctp-tools_1.0.7.bb | 8 ++++ > 2 files changed, 55 insertions(+) > create mode 100644 meta-arago-extras/recipes-bsp/lksctp- >tools/lksctp-tools.inc > create mode 100755 meta-arago-extras/recipes-bsp/lksctp- >tools/lksctp-tools_1.0.7.bb > >diff --git a/meta-arago-extras/recipes-bsp/lksctp-tools/lksctp- >tools.inc b/meta-arago-extras/recipes-bsp/lksctp-tools/lksctp- >tools.inc >new file mode 100644 >index 0000000..8a66dc9 >--- /dev/null >+++ b/meta-arago-extras/recipes-bsp/lksctp-tools/lksctp-tools.inc >@@ -0,0 +1,47 @@ >+DESCRIPTION = "The Linux Kernel Stream Control Transmission >Protocol (lksctp) project" >+SECTION = "libs" >+PRIORITY = "optional" >+LICENSE = "LGPLv2" >+ >+S = "${WORKDIR}/${BPN}-${PV}" >+ >+INC_PR = "r1" >+ >+BBCLASSEXTEND = "native" >+ >+inherit autotools pkgconfig binconfig >+ >+do_install_append_virtclass-native() { >+ : >+} I find this confusing. You are appending a do nothing to a function? >+ >+RREPLACES = "lksctp" >+ >+LEAD_SONAME = "libsctp.so" >+ >+PACKAGES =+ "${PN}-withsctp ${PN}-utils" >+ >+FILES_${PN} = "${libexecdir}/* ${libdir}/lib*${SOLIBS} \ >+ ${sysconfdir} ${sharedstatedir} ${localstatedir} \ >+ ${base_libdir}/*${SOLIBS}" >+ >+FILES_${PN}-withsctp = " \ >+ ${libdir}/lksctp-tools/lib*" >+ >+FILES_${PN}-dev += " \ >+ ${datadir}/lksctp-tools/checksctp.c \ >+ ${datadir}/lksctp-tools/sctp_socket.c \ >+ ${datadir}/lksctp-tools/sctp_bind.c \ >+ ${datadir}/lksctp-tools/sctp_darn.c \ >+ ${datadir}/lksctp-tools/sctp_load_libs.c \ >+ ${datadir}/lksctp-tools/sctp_sockopt.c \ >+ ${datadir}/lksctp-tools/sctp_socket.h \ >+ ${datadir}/lksctp-tools/sctp_test.c \ >+ ${datadir}/lksctp-tools/sctp_darn.h" >+ >+FILES_${PN}-utils = " \ >+ ${bindir}/sctp_test \ >+ ${bindir}/sctp_darn \ >+ ${bindir}/checksctp \ >+ ${bindir}/withsctp" >+ >diff --git a/meta-arago-extras/recipes-bsp/lksctp-tools/lksctp- >tools_1.0.7.bb b/meta-arago-extras/recipes-bsp/lksctp- >tools/lksctp-tools_1.0.7.bb >new file mode 100755 >index 0000000..000bc31 >--- /dev/null >+++ b/meta-arago-extras/recipes-bsp/lksctp-tools/lksctp- >tools_1.0.7.bb >@@ -0,0 +1,8 @@ >+require lksctp-tools.inc >+PR = "${INC_PR}.0" >+ >+SRC_URI = "${SOURCEFORGE_MIRROR}/lksctp/lksctp-tools- >${PV}.tar.gz" >+ >+SRC_URI[md5sum] = "047562b40537eb3be5d5ec3ae0a2198b" >+SRC_URI[sha256sum] = >"e920e89d110cff9847f1d86a1d7a23a156a8abcc9e65a35655d687fd08377595" >+ >-- >1.7.9.5 > >_______________________________________________ >meta-arago mailing list >[email protected] >http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago _______________________________________________ meta-arago mailing list [email protected] http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
