BTW, does this belong in meta-ti instead of meta-arago?
>-----Original Message----- >From: [email protected] [mailto:meta-arago- >[email protected]] On Behalf Of Maupin, Chase >Sent: Friday, May 16, 2014 1:32 PM >To: Nelson, Sam; [email protected] >Subject: Re: [meta-arago] [PATCH] ti-hyplnk: Add recipe for ti >hyperlink low level driver > >>-----Original Message----- >>From: [email protected] [mailto:meta-arago- >>[email protected]] On Behalf Of Nelson, Sam >>Sent: Sunday, March 02, 2014 5:23 PM >>To: [email protected] >>Subject: [meta-arago] [PATCH] ti-hyplnk: Add recipe for ti >>hyperlink low level driver >> >>- User space low level driver and test code for hyperlink >> peripheral >> >>Signed-off-by: Sam Nelson <[email protected]> >>--- >> .../recipes-bsp/ti-hyplnk/ti-hyplnk-bin_git.bb | 38 >>++++++++++++++++++++ >> .../recipes-bsp/ti-hyplnk/ti-hyplnk-lib_git.bb | 21 >>+++++++++++ >> .../recipes-bsp/ti-hyplnk/ti-hyplnk.inc | 10 ++++++ >> 3 files changed, 69 insertions(+) >> create mode 100755 meta-arago-extras/recipes-bsp/ti-hyplnk/ti- >>hyplnk-bin_git.bb >> create mode 100755 meta-arago-extras/recipes-bsp/ti-hyplnk/ti- >>hyplnk-lib_git.bb >> create mode 100644 meta-arago-extras/recipes-bsp/ti-hyplnk/ti- >>hyplnk.inc >> >>diff --git a/meta-arago-extras/recipes-bsp/ti-hyplnk/ti-hyplnk- >>bin_git.bb b/meta-arago-extras/recipes-bsp/ti-hyplnk/ti-hyplnk- >>bin_git.bb >>new file mode 100755 >>index 0000000..9938b18 >>--- /dev/null >>+++ b/meta-arago-extras/recipes-bsp/ti-hyplnk/ti-hyplnk- >bin_git.bb >>@@ -0,0 +1,38 @@ >>+DESCRIPTION = "TI HYPLNK low level driver test binaries" >>+LICENSE = "TI BSD" > >Include this in the .inc file since it is common between the two. >Although I might question whether you really need two separate >recipes and a .inc file or if you could use a single recipe and >make different packages, i.e. PN and PN-lib > >>+ >>+COMPATIBLE_MACHINE = "keystone" > >Common between both recipes > >>+ >>+PR = "r0" >>+DEPENDS="ti-csl ti-hyplnk-lib" > >Common between both recipes > >>+ >>+include ti-hyplnk.inc >>+ >>+BASEDIR = "${WORKDIR}/git" >>+S = "${BASEDIR}/ti/drv/${LLDNAME}" > >Common beween both recipes > >>+ >>+DEVICELIST = " k2h \ >>+ k2k \ >>+" > >If you start using machines per device type do you still want to >install K2H and K2K binaries and libraries into both or rather >make this recipe machine specific ARCH and build and install only >the libraries for that device? > >>+ >>+CHOICELIST = " yes \ >>+ no \ >>+" > >Can you elaborate on these options here? Do you really need >dynamic library and static library versions? Would it be better >to package them separately or one as a -dbg package for example? > >>+ >>+do_compile () { >>+ make -f makefile_armv7 clean >>PDK_INSTALL_PATH=${STAGING_INCDIR} HYPLNK_SRC_DIR=${PWD} > >This use of ${PWD} can cause you problems because it assumes you >are in a certain directory. That can be painful when someone >appends or prepends you. I would instead use ${S} or some such >equivalent. > >>+ for device in ${DEVICELIST} >>+ do >>+ for choice in ${CHOICELIST} >>+ do >>+ make -f makefile_armv7 tests examples >>PDK_INSTALL_PATH=${STAGING_INCDIR} DEVICE="${device}" >>HYPLNK_SRC_DIR=${S} USEDYNAMIC_LIB="${choice}" >>+ done >>+ done >>+} >>+ >>+do_install () { >>+ for device in ${DEVICELIST} >>+ do >>+ make -f makefile_armv7 installbin >>PDK_INSTALL_PATH=${STAGING_INCDIR} DEVICE="${device}" >>HYPLNK_SRC_DIR=${S} INSTALL_BIN_BASE_DIR=${D}/${bindir} >>+ done > >To help with the review can you detail what the resulting >directory structure and files looks like after this install step? > >>+} >>diff --git a/meta-arago-extras/recipes-bsp/ti-hyplnk/ti-hyplnk- >>lib_git.bb b/meta-arago-extras/recipes-bsp/ti-hyplnk/ti-hyplnk- >>lib_git.bb >>new file mode 100755 >>index 0000000..03399c6 >>--- /dev/null >>+++ b/meta-arago-extras/recipes-bsp/ti-hyplnk/ti-hyplnk- >lib_git.bb >>@@ -0,0 +1,21 @@ > >I think you can combine this with the previous recipe and just >make a -lib package. > >>+DESCRIPTION = "TI HYPLNK Low Level Driver" >>+LICENSE = "TI BSD" >>+ >>+COMPATIBLE_MACHINE = "keystone" >>+ >>+PR = "r0" >>+DEPENDS="ti-csl" >>+ >>+include ti-hyplnk.inc >>+ >>+BASEDIR = "${WORKDIR}/git" >>+S = "${BASEDIR}/ti/drv/${LLDNAME}" >>+ >>+do_compile () { >>+# Now build the lld in the updated directory >>+ make -f makefile_armv7 clean lib >>PDK_INSTALL_PATH=${STAGING_INCDIR} >>+} >>+ >>+do_install () { >>+ make -f makefile_armv7 install >>PDK_INSTALL_PATH=${STAGING_INCDIR} >>INSTALL_INC_BASE_DIR=${D}/${includedir} >>INSTALL_LIB_BASE_DIR=${D}${libdir} >>+} >>diff --git a/meta-arago-extras/recipes-bsp/ti-hyplnk/ti- >hyplnk.inc >>b/meta-arago-extras/recipes-bsp/ti-hyplnk/ti-hyplnk.inc >>new file mode 100644 >>index 0000000..26f22db >>--- /dev/null >>+++ b/meta-arago-extras/recipes-bsp/ti-hyplnk/ti-hyplnk.inc >>@@ -0,0 +1,10 @@ >>+LLDNAME="hyplnk" >>+ >>+LIC_FILES_CHKSUM = >>"file://${WORKDIR}/git/ti/drv/${LLDNAME}/COPYING.txt;md5=5bdceac8 >7 >>2dffdec915b819654ee23ea" >>+ >>+BRANCH="master" >>+SRC_URI = "git://git.ti.com/keystone-rtos/hyplnk- >>lld.git;destsuffix=git/ti/drv/${LLDNAME};protocol=git;branch=${BR >A >>NCH}" >>+# Following commit corresponds to tag DEV.HYPLNK_LLD.02.00.00.09 >>+SRCREV = "f88e31b60aa2b4d591d5a845361c7e56792eeda1" >>+ >>+PV = "2.0.0" >>\ No newline at end of file >>-- >>1.7.9.5 >> >>_______________________________________________ >>meta-arago mailing list >>[email protected] >>http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago >_______________________________________________ >meta-arago mailing list >[email protected] >http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago _______________________________________________ meta-arago mailing list [email protected] http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
