On Mon, Sep 08, 2014 at 06:08:01PM -0400, Denys Dmytriyenko wrote: > On Mon, Sep 08, 2014 at 06:05:02PM -0400, Cooper Jr., Franklin wrote: > > > > > > > -----Original Message----- > > > From: Dmytriyenko, Denys > > > Sent: Monday, September 08, 2014 4:43 PM > > > To: Cooper Jr., Franklin > > > Cc: Denys Dmytriyenko; [email protected] > > > Subject: Re: [meta-arago] [tisdk-build-scripts][PATCH 1/2] run-opentest: > > > only > > > pass u-boot and spl/uart when enabled in config > > > > > > On Mon, Sep 08, 2014 at 09:39:29PM +0000, Cooper Jr., Franklin wrote: > > > > Should we make this variable specific to am335x some how then? > > > > > > I don't think there's easy way to control a config variable based on > > > machine... > > [Franklin] Maybe for now just check against the "machine" or some regexp > > am335x*? > > > > Also can we update all the configs to use true for now? This way it doesn't > > change the current behavior. With my above suggestion we can set things to > > true and take advantage of it when it makes sense. > > Actually, I was going to disable it for all my configs, as it makes things > worse if enabled - don't know why, but systest is not yet explaining this > behaviour. You can keep it enabled, if you want, in your configs, though.
Ping on this one. Carlos said that passing this to a platform not supporting SPL/UART boot will interfere with normal boot and cause issues we are seeing now. So, it's best to have it disabled by default and only enable it for 335. > > > > > -----Original Message----- > > > > > From: [email protected] [mailto:meta-arago- > > > > > [email protected]] On Behalf Of Denys Dmytriyenko > > > > > Sent: Monday, September 08, 2014 2:49 PM > > > > > To: [email protected] > > > > > Subject: [meta-arago] [tisdk-build-scripts][PATCH 1/2] run-opentest: > > > > > only > > > > > pass u-boot and spl/uart when enabled in config > > > > > > > > > > From: Denys Dmytriyenko <[email protected]> > > > > > > > > > > Introduce new variable OPENTEST_BOOTLOADERS to control it, but > > > defaults > > > > > to false. > > > > > This never worked as expected, since SPL/UART is only supported by > > > am335x > > > > > and on other platforms it causes OpenTest to miss the escape window > > > and it > > > > > can't stop boot sequence to configure the necessary parameters. > > > > > > > > > > Signed-off-by: Denys Dmytriyenko <[email protected]> > > > > > --- > > > > > configs/arago-core-tisdk-daisy-puget.txt | 4 ++++ > > > > > lib/run-opentest | 17 ++++++++++------- > > > > > 2 files changed, 14 insertions(+), 7 deletions(-) > > > > > > > > > > diff --git a/configs/arago-core-tisdk-daisy-puget.txt b/configs/arago- > > > core- > > > > > tisdk-daisy-puget.txt > > > > > index c132baf..f8bfb7a 100644 > > > > > --- a/configs/arago-core-tisdk-daisy-puget.txt > > > > > +++ b/configs/arago-core-tisdk-daisy-puget.txt > > > > > @@ -177,6 +177,10 @@ OPENTEST_TEE_IP="none" > > > > > # Limit the board selection to official TI GT farm, avoiding personal > > > boards > > > > > OPENTEST_HW_CAP="linux_tigt_farm" > > > > > > > > > > +# Determine whether SPL/UART and U-boot binaries are passed to > > > > > OpenTest > > > > > +for # testing. Otherwise uses existing bootloaders on the board (SD, > > > > > +NAND, etc) OPENTEST_BOOTLOADERS="false" > > > > > + > > > > > # This variable will allow control over whether to perform build > > > > > testing or > > > # > > > > > skip it. This should usually be set to true but may be changed for # > > > > > prototyping. > > > > > diff --git a/lib/run-opentest b/lib/run-opentest index > > > > > a64e4cc..1a71ae8 > > > > > 100644 > > > > > --- a/lib/run-opentest > > > > > +++ b/lib/run-opentest > > > > > @@ -206,15 +206,18 @@ run_target_side_test() { > > > > > fi > > > > > > > > > > uboot="" > > > > > - if [ -f $test_dir/temp/board-support/prebuilt-images/u-boot-$m.* > > > > > ] > > > > > - then > > > > > - uboot="~secondary_bootloader=$(ls $test_dir/temp/board- > > > > > support/prebuilt-images/u-boot-$m.*)" > > > > > - fi > > > > > - > > > > > spluart="" > > > > > - if [ -f > > > > > $test_dir/temp/board-support/prebuilt-images/u-boot-spl.bin- > > > $m ] > > > > > + if [ "$OPENTEST_BOOTLOADERS" == "true" ] > > > > > then > > > > > - spluart="~primary_bootloader=$(ls $test_dir/temp/board- > > > > > support/prebuilt-images/u-boot-spl.bin-$m)" > > > > > + if [ -f > > > > > $test_dir/temp/board-support/prebuilt-images/u-boot-$m.* ] > > > > > + then > > > > > + uboot="~secondary_bootloader=$(ls $test_dir/temp/board- > > > > > support/prebuilt-images/u-boot-$m.*)" > > > > > + fi > > > > > + > > > > > + if [ -f $test_dir/temp/board-support/prebuilt-images/u-boot- > > > spl.bin-$m > > > > > ] > > > > > + then > > > > > + spluart="~primary_bootloader=$(ls $test_dir/temp/board- > > > > > support/prebuilt-images/u-boot-spl.bin-$m)" > > > > > + fi > > > > > fi > > > > > > > > > > # Start the STAF process if not already started > > > > > -- > > > > > 2.0.4 > > > > > > > > > > _______________________________________________ > > > > > meta-arago mailing list > > > > > [email protected] > > > > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago > > > > _______________________________________________ > > > > meta-arago mailing list > > > > [email protected] > > > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago > _______________________________________________ > meta-arago mailing list > [email protected] > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago _______________________________________________ meta-arago mailing list [email protected] http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
