On September 19, 2014 1:04:46 PM PDT, Matt Schuckmann
<[email protected]> wrote:
>Assuming that this is bash script, which I'm pretty sure it is, the {}
>are not required here. In bash {} are used to separate an identifier
>from surrounding text (i.e. ${CREATE_SRCIPK}_foo_bar, without the {}
>bash would look for the variable $CREATE_SRCIPK_foo_bar
>
>I get the same error regardless if the {} are there are not.
>
>The correct way appears to be
>if [ -n "${CREATE_SRCIPK}" ] && [ "${CREATE_SRCIPK}" != "0" ]
>
>I've got a patch that does this for the 2 files that call
>sourceipk_do_create_srcipk directly, I'm not sure if I should send the
>patch it to this list or ? I'm kind of new to this.
>
>Thanks,
>Matt S.
>
>PS. I was wondering if it would be better to use the IRC channel for
>this kind of stuff?
>
>From: Dmytriyenko, Denys [mailto:[email protected]]
>Sent: Friday, September 19, 2014 12:21 PM
>To: Matt Schuckmann
>Cc: [email protected]
>Subject: RE: [meta-arago] Arago build fails if building srcipk is
>disabled
>
>Looks like you forgot curly brackets in the variable... Try copying the
>code I linked before as is - that should work, but I didn't try it
>myself yet, due to traveling...
>
>
>Sent from my Android phone using TouchDown
>(www.nitrodesk.com<http://www.nitrodesk.com>)
>
>-----Original Message-----
>From: Matt Schuckmann [[email protected]]
>Received: Thursday, 18 Sep 2014, 15:56
>To: Dmytriyenko, Denys [[email protected]]
>CC: [email protected]<mailto:[email protected]>
>[[email protected]]
>Subject: RE: [meta-arago] Arago build fails if building srcipk is
>disabled
>
>
>> -----Original Message-----
>> From: Denys Dmytriyenko [mailto:[email protected]]
>> Sent: Thursday, September 18, 2014 2:46 PM
>> To: Matt Schuckmann
>> Cc: [email protected]<mailto:[email protected]>
>> Subject: Re: [meta-arago] Arago build fails if building srcipk is
>> disabled
>>
>> On Thu, Sep 18, 2014 at 02:02:24PM -0700, Matt Schuckmann wrote:
>> > I've been chasing this for a bit and I think I've almost got it
>> figured out.
>> > I've been trying to create a new DISTRO based on Arago and I keep
>> getting the following error.
>> >
>> > /home/dev/builds/zanzibar/tisdk/build/arago-tmp-external-linaro-
>> toolch
>> > ain/work/zanziboard-oe-linux-gnueabi/linux-ti-staging/3.14.17-
>> r22e+git
>> > rAUTOINC+1ef37cd35d-arago1/temp/run.do_compile.28819: line 105:
>> > sourceipk_do_create_srcipk: command not found
>> >
>> > I finally figured out that if I included arago-source-ipk.conf in
>my
>> DISTRO file the error goes away.
>> > My understanding is that arago-source-ipk.conf turns on creating
>> srcipk packages for all the packages included in the SDK. I'm not
>> interested in creating srcipk's (at least I don't think I am) since
>I'm
>> not trying to create an SDK I just want a deployable image.
>> >
>> > Digging a little deeper I found that meta-arago-distro/recipes-
>> kernel/linux/copy-defconfig.inc calls sourceipk_do_create_srcipk in a
>> do_compile_prepend() function to pick up any changes to the
>> configuration file and then rebuild the srcipk.
>> >
>> > I think that the do_compile_prepend() function should test the
>value
>> of one of the CREATE_SRCIPK_* variables before it tries to call
>> sourceipk_do_create_srcipk, I'm just not sure which one.
>> > I'm guessing maybe CREATE_SRCIPK_pn-linux-ti-staging but I'm not
>sure
>> or maybe it should test multiple variables?
>> >
>> > I'd appreciate any guidance.
>>
>> Matt,
>>
>> So, the arago-source-ipk.conf defines which components need to create
>> srcipk packages, but it also inherits the sourceipk.bbclass which
>> provides the necessary sourceipk_do_create_srcipk() function. The
>first
>> thing that function does is it checks whether CREATE_SRCIPK variable
>is
>> defined and doesn't do anything if it's not.
>>
>> So, it appears that copy-defconfig.inc should not directly try to
>call
>> that function because it makes the assumption that sourceipk.bbclass
>is
>> always inherited. Simplest workaround would be to check for
>> CREATE_SRCIPK variabe before calling that function, but I wonder if
>> there's a better solution...
>>
>> --
>
>Denys,
>Being new to this I can't really answer the question if there is a
>better way.
>I would like to know the proper way to check for CREATE_SRCIPK so that
>I can move on from this.
>This seems to work but I do not have a high degree of confidence that I
>got it correct, seems like the value should be checked too.
>
>do_compile_prepend() {
> if [ -n "$CREATE_SRCIPK" ]
> then
> cp ${S}/.config ${S}/arch/arm/configs/${CONFIG_NAME}
> sourceipk_do_create_srcipk
> fi
>}
>
>Matt S.
>
>PS.
>I did notice that there is one other recipe doing something similar
>./meta-arago-extras/recipes-bsp/ti-compat-wireless/ti-compat-wireless-wl18xx_r8.a9.14.bb
>
>> Denys
>
>
>------------------------------------------------------------------------
>
>_______________________________________________
>meta-arago mailing list
>[email protected]
>http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
Curly brackets there are for bitbake, not bash... Checking whether the variable
is defined first does make sense though.
--
Denys
_______________________________________________
meta-arago mailing list
[email protected]
http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
