> -----Original Message-----
> From: Dmytriyenko, Denys
> Sent: Thursday, February 05, 2015 11:14 AM
> To: Cooper Jr., Franklin
> Cc: Nelson, Sam; [email protected]
> Subject: Re: [meta-arago] [PATCH] sysvinit: Changing default setting to add
> HWCLOCKACCESS=no
>
> On Thu, Feb 05, 2015 at 12:08:09PM -0500, Cooper Jr., Franklin wrote:
> >
> >
> > > -----Original Message-----
> > > From: Dmytriyenko, Denys
> > > Sent: Thursday, February 05, 2015 10:53 AM
> > > To: Cooper Jr., Franklin
> > > Cc: Nelson, Sam; [email protected]
> > > Subject: Re: [meta-arago] [PATCH] sysvinit: Changing default setting
> > > to add HWCLOCKACCESS=no
> > >
> > > This was supposed to be an RFC, by the way...
> > >
> > >
> > > On Thu, Feb 05, 2015 at 04:45:43PM +0000, Cooper Jr., Franklin wrote:
> > > > I see references to several boards that have enabled rtc in its
> > > > dts file. I didn't check all the boards we support in meta-ti but
> > > > additional boards may use it. So we shouldn't disable it for these
> > > > boards.
> > >
> > > Exactly, so the proposal was to disable it by default and enable
> > > through machine overrides for those boards that have it.
>
> > [Franklin] I'm assuming there was some conversation in the background
> > regarding this patch
>
> Well, not about the patch, but about the problem this patch is trying to fix
> :)
>
>
> > I wasn't aware of since the above two points weren't clear. But no
> > problem doing with what you suggested as long as enabling it for the
> > right boards is being done as part of a patch series with this one.
>
> Do we have a list of boards that have RTC? Just glancing over what I have I
> don't see any...
[Franklin] am437x sk, am437x gp evm and am57x based on looking at the dt.
>
> As an alternative, we can keep it enabled by default and disable it just for
> Keystone to make Sam happy. But I've seen that error on pretty much every
> platform lately.
[Franklin] I would prefer that approach instead. And true about the error but
it could be a bug or error that needs to be fixed so I rather not hide it
especially since I haven't received any questions regarding it before.
>
>
> > > > Honestly if the error is harmless I would say just ignore it.
> > >
> > > That was my initial response - the error is harmless, just ignore
> > > it. Not good for OOB experience, I guess :)
> > >
> > >
> > > > Use some variable that will
> > > > conditional add that string depending on the machine if you want
> > > > to disable it for the machines you care about.
> > >
> > > Just use machine overrides directly, no need to invent another variable...
> > [Franklin] I'll go with whatever you prefer.
> > >
> > >
> > > > Honestly creating a file just to cat it's value to another file I
> > > > feel is a bit of an overkill especially since that file isn't
> > > > generic and is meant for hwclock. So just using echoing something would
> probably be better.
> > > >
> > > > DISABLE_RTC = ""
> > > > DISABLE_<machine> = "yes"
> > > > ....
> > > >
> > > > do_install_append() {
> > > > if [ "${DISABLE_RTC}" = "yes" ]
> > > > then
> > > > echo "#This is to indicate hwclock is not supported" >>
> > > ${D}${sysconfdir}/default/rcS
> > > > echo "HWCLOCKACCESS=no"
> > > > fi
> > > > }
> > > >
> > > >
> > > > > -----Original Message-----
> > > > > From: [email protected] [mailto:meta-arago-
> > > > > [email protected]] On Behalf Of Nelson, Sam
> > > > > Sent: Thursday, February 05, 2015 10:16 AM
> > > > > To: [email protected]
> > > > > Subject: [meta-arago] [PATCH] sysvinit: Changing default setting
> > > > > to add HWCLOCKACCESS=no
> > > > >
> > > > > - realtime clock is not commonly present and hence adding
> > > > > HWCLOCKACCESS=no
> > > > > - Avoids error message if rc device not present
> > > > >
> > > > > Signed-off-by: Sam Nelson <[email protected]>
> > > > > ---
> > > > > .../recipes-core/sysvinit/files/hwclock.rcS | 2 ++
> > > > > .../sysvinit/sysvinit_2.88dsf.bbappend | 9 +++++++++
> > > > > 2 files changed, 11 insertions(+) create mode 100644
> > > > > meta-arago-distro/recipes-
> > > core/sysvinit/files/hwclock.rcS
> > > > > create mode 100644 meta-arago-distro/recipes-
> > > > > core/sysvinit/sysvinit_2.88dsf.bbappend
> > > > >
> > > > > diff --git
> > > > > a/meta-arago-distro/recipes-core/sysvinit/files/hwclock.rcS
> > > b/meta-
> > > > > arago-distro/recipes-core/sysvinit/files/hwclock.rcS
> > > > > new file mode 100644
> > > > > index 0000000..3e26c20
> > > > > --- /dev/null
> > > > > +++ b/meta-arago-distro/recipes-core/sysvinit/files/hwclock.rcS
> > > > > @@ -0,0 +1,2 @@
> > > > > +# This is to indicate hwclock is not supported HWCLOCKACCESS=no
> > > > > diff --git a/meta-arago-distro/recipes-
> > > core/sysvinit/sysvinit_2.88dsf.bbappend
> > > > > b/meta-arago-distro/recipes-core/sysvinit/sysvinit_2.88dsf.bbapp
> > > > > end
> > > > > new file mode 100644
> > > > > index 0000000..6e08c83
> > > > > --- /dev/null
> > > > > +++ b/meta-arago-distro/recipes-core/sysvinit/sysvinit_2.88dsf.b
> > > > > +++ bappend
> > > > > @@ -0,0 +1,9 @@
> > > > > +PR_append = "-arago0"
> > > > > +
> > > > > +# look for files in this layer first FILESEXTRAPATHS_prepend :=
> > > > > +"${THISDIR}/files:"
> > > > > +SRC_URI += "file://hwclock.rcS"
> > > > > +do_install_append () {
> > > > > +# Add hwclock configuration
> > > > > + cat ${WORKDIR}/hwclock.rcS >> ${D}${sysconfdir}/default/rcS }
> > > > > --
> > > > > 1.7.9.5
> > > > >
> > > > > _______________________________________________
> > > > > meta-arago mailing list
> > > > > [email protected]
> > > > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> > > > _______________________________________________
> > > > meta-arago mailing list
> > > > [email protected]
> > > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
_______________________________________________
meta-arago mailing list
[email protected]
http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
