I've been testing the patches since submitting the patches (wanted to get these comments as soon as I could). It seems that this oe_filter_out method is not working as expected...
-----Original Message----- From: Dmytriyenko, Denys Sent: Thursday, March 12, 2015 10:20 AM To: Stiffler, Jacob Cc: [email protected] Subject: Re: [meta-arago] [PATCH 4/4] branding-processor-sdk: Add processor-sdk brand. On Thu, Mar 12, 2015 at 10:00:35AM -0400, Stiffler, Jacob wrote: > What would you suggest? That wayland be controlled as a feature from > each branding file? Or a new variable introduced that arago.conf can > check to decide if wayland should be added to the DISTRO_FEATURES? Leave it like that for now - we'll see if we get any problems... > -----Original Message----- > From: Dmytriyenko, Denys > Sent: Thursday, March 12, 2015 9:57 AM > To: Stiffler, Jacob > Cc: [email protected] > Subject: Re: [meta-arago] [PATCH 4/4] branding-processor-sdk: Add > processor-sdk brand. > > On Thu, Mar 12, 2015 at 08:55:57AM -0400, Jacob Stiffler wrote: > > * Set ARAGO_TISDK_IMAGE to "processor-sdk-linux-image" > > * For now, use sitara-linux-ti-staging > > * and remove wayland feature for ti33x and ti43x soc families. > > > > Signed-off-by: Jacob Stiffler <[email protected]> > > --- > > .../conf/distro/include/branding-processor-sdk.inc | 35 > > ++++++++++++++++++++ > > 1 file changed, 35 insertions(+) > > create mode 100644 > > meta-arago-distro/conf/distro/include/branding-processor-sdk.inc > > > > diff --git > > a/meta-arago-distro/conf/distro/include/branding-processor-sdk.inc > > b/meta-arago-distro/conf/distro/include/branding-processor-sdk.inc > > new file mode 100644 > > index 0000000..5eab952 > > --- /dev/null > > +++ b/meta-arago-distro/conf/distro/include/branding-processor-sdk.i > > +++ nc > > @@ -0,0 +1,35 @@ > > +ARAGO_TISDK_IMAGE = "processor-sdk-linux-image" > > + > > +# Remove wayland from ti33x and ti43x DISTRO_FEATURES. > > +DIRSTO_FEATURES_ti33x = "${@oe_filter_out('DISTRO_FEATURES', 'wayland', > > d)}" > > +DIRSTO_FEATURES_ti43x = "${@oe_filter_out('DISTRO_FEATURES', 'wayland', > > d)}" > > Usually you want immediate assignment here. But I have my doubts it will work > reliably either way, when done like that... > > > > +PREFERRED_PROVIDER_virtual/kernel_am335x-evm = "sitara-linux-ti-staging" > > +PREFERRED_PROVIDER_virtual/kernel_am437x-evm = "sitara-linux-ti-staging" > > +PREFERRED_VERSION_sitara-linux-ti-staging = "3.14%" > > + > > +# To create newlines in the message \n is used and the slash must > > +be escaped # to function properly > > + > > +SRCIPK_GIT_COMMIT_MESSAGE = "\ > > +Create local branch\\n\ > > +\\n\ > > +The below commit is used for this local branch and is the one used > > +by\\n\ this sdk:\\n\ ${SRCREV}." > > + > > +SRCIPK_SHALLOW_GIT_COMMIT_MESSAGE > > +="${SRCIPK_GIT_COMMIT_MESSAGE}\\n\\n\ > > +To reduce the size of the SDK installer only a portion of the git > > +commit\\n\ history has been preserved. Also links to remote > > +branches and tags do\\n\ not exist in this copy of the > > +repository.\\n\ To fix this please run the > > +unshallow-repositories.sh\\n\ script located in the sdk\'s bin > > +directory\\n\ \\n\ The script may take several minutes but you will > > +then have a full copy of\\n\ the git repository including its > > +entire git history.\\n" > > + > > +SRCIPK_CUSTOM_GIT_BRANCH_pn-sitara-linux-ti-staging = "processor-sdk-1.0" > > +SRCIPK_CUSTOM_GIT_MESSAGE_pn-sitara-linux-ti-staging = > > "${SRCIPK_SHALLOW_GIT_COMMIT_MESSAGE}" > > + > > +SRCIPK_CUSTOM_GIT_BRANCH_pn-u-boot-ti-staging = "processor-sdk-1.0" > > +SRCIPK_CUSTOM_GIT_MESSAGE_pn-u-boot-ti-staging = > > "${SRCIPK_GIT_COMMIT_MESSAGE}" > > -- > > 1.7.9.5 > > > > _______________________________________________ > > meta-arago mailing list > > [email protected] > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago _______________________________________________ meta-arago mailing list [email protected] http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
