> -----Original Message-----
> From: Stiffler, Jacob
> Sent: Tuesday, March 17, 2015 1:23 PM
> To: Cooper Jr., Franklin
> Cc: [email protected]
> Subject: RE: [meta-arago] [tisdk-setup-scripts][PATCH] create-sdcard:
> Change SDK install prefix from ti-sdk to processor-sdk.
> 
> I've begun looking into the changes needed to modifying the prefix during
> installation, and I'm not sure quite what to do. Why does this detection need
> to happen?
[Franklin] It probably wants to give you feedback early that you are not using 
the script within the SDK directory aka most likely doesn't contain the files 
you need.. The script probably needs some restructuring if you want to wait 
until the last moment to verify that the correct directory is used and if it 
fails jump back to the portion of the script to allow the user to try again or 
specify another path.

> 
> I guess for installing images from the SDK, I can get that patch from
> installation, but if user wants to enter another SDK location, is there any
> need to verify that the directory has the assumed format? Can the script
> return an error if the images cannot be found within that directory?
[Franklin] The script already has the ability to allow you to manually specify 
the directory to grab tarball and binaries. 
However, if you choose the option to use the prebuilt images from the SDK then 
the assumption is that you want the prebuilt from the current sdk. If not run 
the create sd card script located in the other SDK or select the option within 
the script that will ask you the individual folder name of the rootfs, 
uboot,kernel and dtb.

Honestly I've heard probably three times in three years someone runs into an 
issue using the script since they change the name of the SDK directory during 
installation.  So it is indeed a problem but it is so infrequent that myself 
and others haven't remembered to fix it. Which is essentially the problem your 
having.


> 
> -----Original Message-----
> From: [email protected] [mailto:meta-arago-
> [email protected]] On Behalf Of Stiffler, Jacob
> Sent: Friday, March 13, 2015 1:07 PM
> To: Cooper Jr., Franklin
> Cc: [email protected]
> Subject: Re: [meta-arago] [tisdk-setup-scripts][PATCH] create-sdcard:
> Change SDK install prefix from ti-sdk to processor-sdk.
> 
> Yes, but there is a lot of extra logic which would not be needed.
> 
> -----Original Message-----
> From: Cooper Jr., Franklin
> Sent: Friday, March 13, 2015 10:43 AM
> To: Stiffler, Jacob
> Cc: Dmytriyenko, Denys; [email protected]
> Subject: Re: [meta-arago] [tisdk-setup-scripts][PATCH] create-sdcard:
> Change SDK install prefix from ti-sdk to processor-sdk.
> 
> Well I guess Denys is right and we should play nice with others.
> 
> Sdk_install.sh part would be easy.
> 
> Replace  "*ti-sdk.*.[0-9]/" with the name of the directory since you already
> know it.
> 
> Then it works for anyone
> 
> 
> 
> 
> > On Mar 13, 2015, at 9:02 AM, Stiffler, Jacob <[email protected]> wrote:
> >
> > I'm not sure if we can do that now that the versioning has been reset to
> 1.0.0.0.
> >
> > However, I do plan on submitting an updated patch after this first release.
> This method of autodetecting the SDK installation directory is somewhat
> broken with installbuilder since the user may choose any directory which may
> or may not have the correct format.
> >
> > It seems that the sdk_install.sh script should do some modifications to get
> the explicit directory within the script, but it appears this would take more
> changes which I haven't yet had a chance to look into.
> >
> > -  Jake
> >
> > -----Original Message-----
> > From: Dmytriyenko, Denys
> > Sent: Friday, March 13, 2015 9:58 AM
> > To: Stiffler, Jacob
> > Cc: [email protected]
> > Subject: Re: [meta-arago] [tisdk-setup-scripts][PATCH] create-sdcard:
> Change SDK install prefix from ti-sdk to processor-sdk.
> >
> > This is going to affect all the SDKs - ti-sdk was chosen on purpose to be
> generic enough to cover all our SDKs, not some specific one...
> >
> >
> >> On Fri, Mar 13, 2015 at 09:49:04AM -0400, Jacob Stiffler wrote:
> >> Signed-off-by: Jacob Stiffler <[email protected]>
> >> ---
> >> create-sdcard.sh |   14 +++++++-------
> >> 1 file changed, 7 insertions(+), 7 deletions(-)
> >>
> >> diff --git a/create-sdcard.sh b/create-sdcard.sh index
> >> ca02ad2..17ae564 100644
> >> --- a/create-sdcard.sh
> >> +++ b/create-sdcard.sh
> >> @@ -74,7 +74,7 @@ if [ "$AMIROOT" != "root" ] ; then fi
> >>
> >> THEPWD=$EXEPATH
> >> -PARSEPATH=`echo $THEPWD | grep -o '.*ti-sdk.*.[0-9]/'`
> >> +PARSEPATH=`echo $THEPWD | grep -o '.*processor-sdk.*.[0-9]/'`
> >>
> >> if [ "$PARSEPATH" != "" ] ; then
> >> PATHVALID=1
> >> @@ -703,7 +703,7 @@ if [ $FILEPATHOPTION -eq 1 ] ; then
> >>
> >>    #check that in the right directory
> >>
> >> -    THEEVMSDK=`echo $PARSEPATH | grep -o 'ti-sdk-.*[0-9]'`
> >> +    THEEVMSDK=`echo $PARSEPATH | grep -o 'processor-sdk-.*[0-9]'`
> >>
> >>    if [ $PATHVALID -eq 1 ]; then
> >>    echo "now installing:  $THEEVMSDK"
> >> @@ -720,7 +720,7 @@ if [ $FILEPATHOPTION -eq 1 ] ; then
> >>            then
> >>                echo "Directory exists"
> >>                echo ""
> >> -                PARSEPATH=`echo $SDKFILEPATH | grep -o 
> >> '.*ti-sdk.*.[0-9]/'`
> >> +                PARSEPATH=`echo $SDKFILEPATH | grep -o
> >> + '.*processor-sdk.*.[0-9]/'`
> >>                #echo $PARSEPATH
> >>
> >>                if [ "$PARSEPATH" != "" ] ; then @@ -731,7 +731,7 @@
> >> if [ $FILEPATHOPTION -eq 1 ] ; then
> >>                #echo $PATHVALID
> >>                if [ $PATHVALID -eq 1 ] ; then
> >>
> >> -                THEEVMSDK=`echo $SDKFILEPATH | grep -o 'ti-sdk-.*[0-9]'`
> >> +                THEEVMSDK=`echo $SDKFILEPATH | grep -o
> >> + 'processor-sdk-.*[0-9]'`
> >>                echo "Is this the correct SDK: $THEEVMSDK"
> >>                echo ""
> >>                read -p 'Is this correct? [y/n] : ' ISRIGHTPATH @@
> >> -741,7 +741,7 @@ if [ $FILEPATHOPTION -eq 1 ] ; then
> >>                    *)  echo "Please enter y or n";ENTERCORRECTLY=0;;
> >>                    esac
> >>                else
> >> -                echo "Invalid SDK path make sure to include ti-sdk-xxxx"
> >> +                echo "Invalid SDK path make sure to include 
> >> processor-sdk-xxxx"
> >>                ENTERCORRECTLY=0
> >>                fi
> >>
> >> @@ -804,7 +804,7 @@ cat << EOM
> >>       e.x. $:  /home/user/MyCustomTars/boot.tar.gz
> >>
> >>   If files are located in a directory write the directory path
> >> -      e.x. $: /ti-sdk/board-support/prebuilt-images/
> >> +      e.x. $: /processor-sdk/board-support/prebuilt-images/
> >>
> >>   NOTE: Not all platforms will have an MLO file and this file can
> >>         be ignored for platforms that do not support an MLO.
> >> @@ -937,7 +937,7 @@ cat << EOM
> >>       e.x. $:  /home/user/MyCustomTars/rootfs.tar.gz
> >>
> >>   If files are located in a directory write the directory path
> >> -      e.x. $: /ti-sdk/targetNFS/
> >> +      e.x. $: /processor-sdk/targetNFS/
> >>
> >>
> ##########################################################
> ###########
> >> ###########
> >>
> >> --
> >> 1.7.9.5
> >>
> >> _______________________________________________
> >> meta-arago mailing list
> >> [email protected]
> >> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> > _______________________________________________
> > meta-arago mailing list
> > [email protected]
> > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> _______________________________________________
> meta-arago mailing list
> [email protected]
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
_______________________________________________
meta-arago mailing list
[email protected]
http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago

Reply via email to