Hi Eric, I would prefer a recipe update to address a specific issue/feature rather than taking in all patches at once. This will help in better traceability when we move to next Yocto version. For example, when we move to a later Weston version, few patches may not be relevant. If we separate each feature into a separate recipe commit, rebasing becomes easier.
Ideally, we should have a morty patch for each patch on Krogoth. In specific cases, we may want to squash. Hence, we should logically segregate the patches to be applied and have specific recipe updates targeting each of them. We also want to change the name of this patch file removing 1.9.0 from the file name. Can you rebase this change on top of my v2 patch? We will need similar updates for other patches as well - let's plan for respective patch owners take care of that. On a related note, just like kernel commits, each patch owner should be tracking recipe commits as well when moving from one LTS to another. This got missed out this time. Regards, Anand -----Original Message----- From: Ruei, Eric Sent: Thursday, March 9, 2017 3:10 AM To: Dmytriyenko, Denys Cc: Balagopalakrishnan, Anand; [email protected] Subject: RE: [meta-arago] [PATCH 1/1] weston: restrict udev enumeration to /dev/dri/card0 Hi, Denys: Anand's patch will fix one problem and we shall need the following additional patch to get Weston up and running. 0002-Weston1.9.0-Allow-visual_id-to-be-0.patch: still applicable, resolve the EGL config problem (LCPD-9399) Best regards, Eric -----Original Message----- From: Dmytriyenko, Denys Sent: Wednesday, March 08, 2017 4:17 PM To: Ruei, Eric Cc: Balagopalakrishnan, Anand; [email protected] Subject: Re: [meta-arago] [PATCH 1/1] weston: restrict udev enumeration to /dev/dri/card0 Eric, Thanks for reviewing all the patches and identifying their status! I can probably merge Anand's patch right away, which would supposed to unblock further Weston testing. And that will give you a bit more time to prepare a followup patch with the rest of them, in case there are any updates needed. Please let me know otherwise. Thanks. -- Denys On Wed, Mar 08, 2017 at 03:56:13PM -0500, Ruei, Eric wrote: > Hi, Anand and Denys: > > I have confirmed that all other 7 Weston patches are still applicable. > > 0001-weston-Enabling-DRM-backend-with-multiple-displays.patch : still > applicable, need a minor update > 0002-Weston1.9.0-Allow-visual_id-to-be-0.patch: still applicable, > resolve the EGL config problem (LCPD-9399) > 0003-Weston1.9.0-Fix-virtual-keyboard-display-issue-for-Q.patch: still > applicable > 0004-Weston1.9.0-Fix-touch-screen-crash-issue.patch: still applicable > 0001-udev-seat-restrict-udev-enumeration-to-card0.patch: still applicable, it > is what Anand just re-enabled. > 0001-Add-soc-performance-monitor-utilites.patch : still applicable, > TI-specific changes > 0001-compositor-drm-support-RGB565-with-pixman-renderer.patch: still > applicable, Tomi has submitted this one a while ago, but it is not > > available at Weston 1.11.0. > 0001-compositor-drm-fix-hotplug-weston-termination-proble.patch: still > applicable, good enough as long as the connecter id/crtc id <64 > > I did submit this patch to trigger discussions, but none has provided > a better solution. > > Should I submit another patch with all other patches after Anand's > patch is applied? Or should we replace Anand's patch with this one > which covers all Weston 1.9 patches? > > Best regards, > > Eric > > > > -----Original Message----- > From: [email protected] > [mailto:[email protected]] On Behalf Of > Balagopalakrishnan, Anand > Sent: Wednesday, March 08, 2017 12:22 PM > To: Dmytriyenko, Denys > Cc: [email protected] > Subject: Re: [meta-arago] [PATCH 1/1] weston: restrict udev > enumeration to /dev/dri/card0 > > Denys, > > We need to review whether the other patches are required or not. This action > will happen over the next 1-2 weeks by Karthik and Eric. Till that time, I > would like to keep the patches in. > > In the meantime, the commented out lines can be removed from the bbappend > file itself. If a patch is deemed to be required, we can submit a new recipe > update later for SRC_URL. Is this fine? If so, I can submit v2 with this > proposal. > > Regards, > Anand > ________________________________________ > From: Dmytriyenko, Denys > Sent: Wednesday, March 08, 2017 8:06 PM > To: Balagopalakrishnan, Anand > Cc: [email protected] > Subject: Re: [meta-arago] [PATCH 1/1] weston: restrict udev > enumeration to /dev/dri/card0 > > On Wed, Mar 08, 2017 at 01:28:25PM +0530, Anand Balagopalakrishnan wrote: > > Signed-off-by: Anand Balagopalakrishnan <[email protected]> > > --- > > .../wayland/weston_1.11.0.bbappend | 23 > > +++++++++++----------- > > 1 file changed, 12 insertions(+), 11 deletions(-) > > > > diff --git > > a/meta-arago-distro/recipes-graphics/wayland/weston_1.11.0.bbappend > > b/meta-arago-distro/recipes-graphics/wayland/weston_1.11.0.bbappend > > index d0691ad..36585bd 100644 > > --- > > a/meta-arago-distro/recipes-graphics/wayland/weston_1.11.0.bbappend > > +++ b/meta-arago-distro/recipes-graphics/wayland/weston_1.11.0.bbapp > > +++ en > > +++ d > > @@ -2,19 +2,20 @@ > > PACKAGECONFIG[fbdev] = "--enable-fbdev-compositor > > WESTON_NATIVE_BACKEND="fbdev-backend.so",--disable-fbdev-compositor,udev > > mtdev" > > PACKAGECONFIG[kms] = "--enable-drm-compositor,--disable-drm-compositor,drm > > udev libgbm mtdev" > > > > -PR_append = ".arago16" > > +PR_append = ".arago17" > > > > FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:" > > > > RDEPENDS_${PN} += "weston-conf" > > > > -#SRC_URI += " \ > > -# > > file://0001-weston1.9.0-Enabling-DRM-backend-with-multiple-displ.patch \ > > -# file://0002-Weston1.9.0-Allow-visual_id-to-be-0.patch \ > > -# > > file://0003-Weston1.9.0-Fix-virtual-keyboard-display-issue-for-Q.patch \ > > -# file://0004-Weston1.9.0-Fix-touch-screen-crash-issue.patch \ > > -# file://0001-udev-seat-restrict-udev-enumeration-to-card0.patch \ > > -# file://0001-Add-soc-performance-monitor-utilites.patch \ > > -# file://0001-compositor-drm-support-RGB565-with-pixman-renderer.patch \ > > -# > > file://0001-compositor-drm-fix-hotplug-weston-termination-proble.patch \ > > -#" > > + > > +SRC_URI += " \ > > + file://0001-udev-seat-restrict-udev-enumeration-to-card0.patch > > +\ " > > +# file://0001-weston1.9.0-Enabling-DRM-backend-with-multiple-displ.patch > > +# file://0002-Weston1.9.0-Allow-visual_id-to-be-0.patch > > +# file://0003-Weston1.9.0-Fix-virtual-keyboard-display-issue-for-Q.patch > > +# file://0004-Weston1.9.0-Fix-touch-screen-crash-issue.patch > > +# file://0001-Add-soc-performance-monitor-utilites.patch > > +# file://0001-compositor-drm-support-RGB565-with-pixman-renderer.patch > > +# file://0001-compositor-drm-fix-hotplug-weston-termination-proble.patch > > Anand, > > What about the rest of the commented out patches? Do we still need them? > > If we need them, will you be looking at up-porting them? > If we don't need them, can you please remove the corresponding comments from > the recipe. > > Thanks. > > -- > Denys > _______________________________________________ > meta-arago mailing list > [email protected] > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago _______________________________________________ meta-arago mailing list [email protected] http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
