Hi, Denys: It is my bad. Please drop this patch. I need to submit another one for AM4 where AM4/5 should stay the same. I shall look into AM3 to see whether I can revise the patch for AM3.
Best regards, Eric -----Original Message----- From: Dmytriyenko, Denys Sent: Wednesday, May 31, 2017 1:40 PM To: Ruei, Eric Cc: [email protected] Subject: Re: [meta-arago] [morty/master][PATCH] gstreamer1.0-plugins-bad: Apply gstwaylandsink scale-up issue fix to AM3/4 Eric, This breaks builds for am3x: | ../../../gst-plugins-bad-1.8.3/ext/wayland/wlwindow.c: In function 'gst_wl_window_resize_video_surface': | ../../../gst-plugins-bad-1.8.3/ext/wayland/wlwindow.c:255:22: error: 'GstWlDisplay {aka struct _GstWlDisplay}' has no member named 'crop' | if (window->display->crop) { | ^~ | ../../../gst-plugins-bad-1.8.3/ext/wayland/wlwindow.c:256:72: error: 'GstWlDisplay {aka struct _GstWlDisplay}' has no member named 'crop' | wl_viewport_set_destination (window->area_viewport, window->display->crop->width, window->display->crop->height); | | ^~ | ../../../gst-plugins-bad-1.8.3/ext/wayland/wlwindow.c:256:103: error: 'GstWlDisplay {aka struct _GstWlDisplay}' has no member named 'crop' | wl_viewport_set_destination (window->area_viewport, window->display->crop->width, window->display->crop->height); | | ^~ | ../../../gst-plugins-bad-1.8.3/ext/wayland/wlwindow.c:257:73: error: 'GstWlDisplay {aka struct _GstWlDisplay}' has no member named 'crop' | wl_viewport_set_destination (window->video_viewport, window->display->crop->width, window->display->crop->height); | | ^~ | ../../../gst-plugins-bad-1.8.3/ext/wayland/wlwindow.c:257:104: error: 'GstWlDisplay {aka struct _GstWlDisplay}' has no member named 'crop' | wl_viewport_set_destination (window->video_viewport, window->display->crop->width, window->display->crop->height); | | ^~ | Makefile:935: recipe for target 'libgstwaylandsink_la-wlwindow.lo' | failed | make[3]: *** [libgstwaylandsink_la-wlwindow.lo] Error 1 | make[3]: *** Waiting for unfinished jobs.... | ../../../gst-plugins-bad-1.8.3/ext/wayland/wldisplay.c:299:6: warning: | no previous prototype for 'pointer_axis_stop' [-Wmissing-prototypes] void pointer_axis_stop(void *data, struct wl_pointer *wl_pointer, uint32_t time, uint32_t axis) | ^~~~~~~~~~~~~~~~~ | make[3]: Leaving directory '/OE/arago-morty-next-build/build-CORTEX_1/arago-tmp-external-linaro-toolchain/work/am335x_evm-linux-gnueabi/gstreamer1.0-plugins-bad/1.8.3-r5/build/ext/wayland' | Makefile:1331: recipe for target 'wayland' failed | make[2]: *** [wayland] Error 2 Full logs: http://lcpd.gt.design.ti.com/builds/arago-morty-next/systest/am335x-evm/17645/logs/am335x-evm-error-logs/gstreamer1.0-plugins-bad_1.8.3-r5_do_compile.log On Thu, May 25, 2017 at 07:26:30PM -0400, Eric Ruei wrote: > Pick the patch: > 1. 0006-gstwaylandsink-Fix-scale-up-with-padded-video.patch > > Signed-off-by: Pooja Prajod <[email protected]> > Signed-off-by: Eric Ruei <[email protected]> > --- > .../gstreamer/gstreamer1.0-plugins-bad_1.8.3.bbappend | 2 > ++ > 1 file changed, 2 insertions(+) > > diff --git > a/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins- > bad_1.8.3.bbappend > b/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins- > bad_1.8.3.bbappend > index ff61132..3e6c8a5 100644 > --- > a/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins- > bad_1.8.3.bbappend > +++ b/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plug > +++ ins-bad_1.8.3.bbappend > @@ -28,11 +28,13 @@ SRC_URI_append_ti43x = " \ > file://0003-kmssink-add-YUYV-support.patch \ > file://0001-gstwaylandsink-add-input-format-I420-support.patch \ > > file://0005-gstwaylandsink-Implement-callbacks-for-version-5-of-.patch > \ > + file://0006-gstwaylandsink-Fix-scale-up-with-padded-video.patch \ > " > > SRC_URI_append_ti33x = " \ > file://0001-gstwaylandsink-Add-mouse-drag-and-drop-support.patch \ > > file://0005-gstwaylandsink-Implement-callbacks-for-version-5-of-.patch > \ > + file://0006-gstwaylandsink-Fix-scale-up-with-padded-video.patch \ > " > > SRC_URI_append_omap-a15 = " \ > -- > 1.9.1 > > _______________________________________________ > meta-arago mailing list > [email protected] > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago _______________________________________________ meta-arago mailing list [email protected] http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
