On Thu, Nov 09, 2017 at 09:33:46PM +0800, Karthik Ramanan wrote: > Denys, > > > On 08-Nov-17 10:45 PM, Denys Dmytriyenko wrote: > >On Wed, Nov 08, 2017 at 05:36:33PM +0800, Karthik Ramanan wrote: > >>Looks good. ACK. > >Where's the patch? > Are you referring to the patch missing in the patchwork on the > meta-arago list? Even I was wondering why I couldn't find it.
The patch was not on the list. > Or is it something else? > > > > > >>On 08-Nov-17 11:41 AM, Ramprasad N wrote: > >>>Signed-off-by: Ramprasad N <[email protected]> > >>>--- > >>> ...v4l2src-Increase-minimum-num-buffers-by-4.patch | 33 > >>> ++++++++++++++++++++++ > >>> .../gstreamer1.0-plugins-good_1.8.3.bbappend | 8 ++++++ > >>> 2 files changed, 41 insertions(+) > >>> create mode 100644 > >>> meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good/0001-v4l2src-Increase-minimum-num-buffers-by-4.patch > >>> create mode 100644 > >>> meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.8.3.bbappend > >>> > >>>diff --git > >>>a/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good/0001-v4l2src-Increase-minimum-num-buffers-by-4.patch > >>> > >>>b/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good/0001-v4l2src-Increase-minimum-num-buffers-by-4.patch > >>>new file mode 100644 > >>>index 0000000..1af90c1 > >>>--- /dev/null > >>>+++ > >>>b/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good/0001-v4l2src-Increase-minimum-num-buffers-by-4.patch > >>>@@ -0,0 +1,33 @@ > >>>+From 73254df370fec6a2eb1ae6711955307a1d4bf173 Mon Sep 17 00:00:00 2001 > >>>+From: Ramprasad N <[email protected]> > >>>+Date: Fri, 13 Oct 2017 15:48:06 +0530 > >>>+Subject: [PATCH] v4l2src: Increase minimum num buffers by 4 > >>>+ > >>>+v4l2src plugin allocates 4 buffers for the pipeline. > >>>+To capture video in realtime the pipeline without frameloss, > >>>+four buffers are not sufficient. Increase the > >>>+number of buffers by 4 more. > >>>+ > >>>+Signed-off-by: Ramprasad N <[email protected]> > >>>+--- > >>>+ sys/v4l2/gstv4l2object.c | 4 +++- > >>>+ 1 file changed, 3 insertions(+), 1 deletion(-) > >>>+ > >>>+diff --git a/sys/v4l2/gstv4l2object.c b/sys/v4l2/gstv4l2object.c > >>>+index 549e06f..773f46d 100644 > >>>+--- a/sys/v4l2/gstv4l2object.c > >>>++++ b/sys/v4l2/gstv4l2object.c > >>>+@@ -3939,7 +3939,9 @@ gst_v4l2_object_decide_allocation (GstV4l2Object * > >>>obj, GstQuery * query) > >>>+ * to fill the pipeline, the minimum required to decoder according > >>>to the > >>>+ * driver and 1 more, so we don't endup up with everything > >>>downstream or > >>>+ * held by the decoder. */ > >>>+- own_min = min + obj->min_buffers + 1; > >>>++ /* Increase the number of buffers required by 4 more to capture > >>>video in > >>>++ * realtime. With default number of 4 buffers, frame loss is > >>>observed */ > >>>++ own_min = min + obj->min_buffers + 5; > >>>+ > >>>+ /* If no allocation parameters where provided, allow for a little > >>>more > >>>+ * buffers and enable copy threshold */ > >>>+-- > >>>+1.9.1 > >>>+ > >>>diff --git > >>>a/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.8.3.bbappend > >>> > >>>b/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.8.3.bbappend > >>>new file mode 100644 > >>>index 0000000..29a07b2 > >>>--- /dev/null > >>>+++ > >>>b/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.8.3.bbappend > >>>@@ -0,0 +1,8 @@ > >>>+PR_append = ".arago0" > >>>+ > >>>+FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:" > >>>+ > >>>+SRC_URI += " \ > >>>+ file://0001-v4l2src-Increase-minimum-num-buffers-by-4.patch \ > >>>+ " > >>>+ > >>_______________________________________________ > >>meta-arago mailing list > >>[email protected] > >>http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago > _______________________________________________ meta-arago mailing list [email protected] http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
