> -----Original Message-----
> From: Stiffler, Jacob
> Sent: Monday, March 19, 2018 6:11 PM
> To: Gou, Hongmei; [email protected]
> Subject: Re: [EXTERNAL] [meta-arago] [meta-processor-sdk] [PATCH] tiovx-
> sys-iface: use update-alternatives for the firmware
> 
> 
> 
> On 3/19/2018 5:56 PM, Hongmei Gou wrote:
> > Signed-off-by: Hongmei Gou <[email protected]>
> > ---
> >   recipes-ti/tiovx/tiovx-sys-iface.bb | 11 ++++++++++-
> >   1 file changed, 10 insertions(+), 1 deletion(-)
> >
> > diff --git a/recipes-ti/tiovx/tiovx-sys-iface.bb
> > b/recipes-ti/tiovx/tiovx-sys-iface.bb
> > index 4462749..bcfbcc9 100644
> > --- a/recipes-ti/tiovx/tiovx-sys-iface.bb
> > +++ b/recipes-ti/tiovx/tiovx-sys-iface.bb
> > @@ -7,11 +7,13 @@ LIC_FILES_CHKSUM = "file://iface/VSDK/docs/TIOVX-
> SYS-IFACE_1.0.0.0_manifest.html
> >   require recipes-ti/includes/tisdk-paths.inc
> >   require tiovx-sys.inc
> >
> > -PR = "r1"
> > +PR = "r0"
> 
> The PR value should not be decreased.
> 
PV in tiovx-sys.inc has been changed from 01.00.00.00 to 01.00.01.00. So, 
starting from r0 here.

> >
> >   COMPATIBLE_MACHINE = "dra7xx"
> >   PACKAGE_ARCH = "${MACHINE_ARCH}"
> >
> > +inherit update-alternatives
> > +
> >   S = "${WORKDIR}/git"
> >
> >   do_install () {
> > @@ -24,6 +26,13 @@ do_install () {
> >       install -m 0644 ${S}/firmware/tiovx_dsp2.xe66
> ${D}/${base_libdir}/firmware/dra7-dsp2-fw.xe66.openvx
> >   }
> >
> > +ALTERNATIVE_${PN} = "dra7-dsp1-fw.xe66 dra7-dsp2-fw.xe66"
> > +ALTERNATIVE_LINK_NAME[dra7-dsp1-fw.xe66] =
> "${base_libdir}/firmware/dra7-dsp1-fw.xe66"
> > +ALTERNATIVE_TARGET[dra7-dsp1-fw.xe66] =
> "${base_libdir}/firmware/dra7-dsp1-fw.xe66.openvx"
> > +ALTERNATIVE_LINK_NAME[dra7-dsp2-fw.xe66] =
> "${base_libdir}/firmware/dra7-dsp2-fw.xe66"
> > +ALTERNATIVE_TARGET[dra7-dsp2-fw.xe66] =
> "${base_libdir}/firmware/dra7-dsp2-fw.xe66.openvx"
> 
> This looks fine, but it may be better to follow the examples in opencl-monitor
> to use ${BPN} instead of the hard-coded "openvx".
> 
> E.g.:
> 
> ALTERNATIVE_LINK_NAME[dra7-dsp1-fw.xe66] =
> "${base_libdir}/firmware/dra7-dsp1-fw.xe66"
> ALTERNATIVE_TARGET[dra7-dsp1-fw.xe66] = "${base_libdir}/firmware/dra7-
> dsp1-fw.xe66.${BPN}"
> ALTERNATIVE_LINK_NAME[dra7-dsp2-fw.xe66] =
> "${base_libdir}/firmware/dra7-dsp2-fw.xe66"
> ALTERNATIVE_TARGET[dra7-dsp2-fw.xe66] = "${base_libdir}/firmware/dra7-
> dsp2-fw.xe66.${BPN}"
> 

The recipe name is tiovx-sys-iface, instead of openvx.
 
> > +ALTERNATIVE_PRIORITY = "20"
> > +
> >   FILES_${PN} += "${TIOVX_INSTALL_DIR_RECIPE}/sys-iface/* "
> >   PACKAGES =+ "${PN}-firmware"
> >   FILES_${PN}-firmware = "${base_libdir}/firmware/*"

_______________________________________________
meta-arago mailing list
[email protected]
http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago

Reply via email to