On Wed, Nov 21, 2018 at 01:55:05PM -0500, Su, Qin wrote:
>
>
> >-----Original Message-----
> >From: Dmytriyenko, Denys
> >Sent: Monday, November 19, 2018 3:19 PM
> >To: Su, Qin
> >Cc: meta-arago@arago-project.org
> >Subject: Re: [meta-arago] [PATCH] arm-compute-library: bump SRCREV and
> >add benchmark test group.
> >
> >On Fri, Nov 16, 2018 at 02:42:22PM -0500, Qin Su wrote:
> >> updated to the latest version of 18.08 updated to generate versioned
> >> library added benchmark preset group for squeezenet and inceptionnet
> >
> >Upstream-Status is missing for all the new pathces.
> >
> >Also see below.
>
> Fixed in patch v2
>
> >
> >> Signed-off-by: Qin Su <q...@ti.com>
> >> ---
> >> .../0001-add-ti-benchmark-test-group.patch | 62
> >+++++++++++++++++++
> >> .../0002-add-ti-benchmark-test-group.patch | 72
> >++++++++++++++++++++++
> >> .../0003-add-ti-benchmark-test-group.patch | 40 ++++++++++++
> >> .../0004-add-ti-benchmark-test-group.patch | 47 ++++++++++++++
> >> .../0005-add-ti-benchmark-test-group.patch | 44 +++++++++++++
> >> .../0006-add-ti-benchmark-test-group.patch | 42 +++++++++++++
> >> .../0007-add-ti-benchmark-test-group.patch | 42 +++++++++++++
> >> .../0008-add-ti-benchmark-test-group.patch | 29 +++++++++
> >> .../0009-add-ti-benchmark-test-group.patch | 42 +++++++++++++
> >> .../0010-add-ti-benchmark-test-group.patch | 48 +++++++++++++++
> >> .../0011-add-ti-benchmark-test-group.patch | 35 +++++++++++
> >> .../arm-compute-library/arm-compute-library_git.bb | 32 ++++++----
> >> 12 files changed, 524 insertions(+), 11 deletions(-)
> >
> >[snip]
> >
> >> diff --git
> >> a/meta-arago-extras/recipes-support/arm-compute-library/arm-compute-li
> >> brary_git.bb
> >> b/meta-arago-extras/recipes-support/arm-compute-library/arm-compute-li
> >> brary_git.bb
> >> index 8a65ade..fc038f9 100644
> >> ---
> >> a/meta-arago-extras/recipes-support/arm-compute-library/arm-compute-li
> >> brary_git.bb
> >> +++ b/meta-arago-extras/recipes-support/arm-compute-library/arm-
> >comput
> >> +++ e-library_git.bb
> >> @@ -1,18 +1,30 @@
> >> SUMMARY = "The ARM Computer Vision and Machine Learning library"
> >> DESCRIPTION = "The ARM Computer Vision and Machine Learning library is
> >a set of functions optimised for both ARM CPUs and GPUs."
> >> LICENSE = "MIT"
> >> -LIC_FILES_CHKSUM =
> >"file://LICENSE;md5=e2c93841b20cd522af621cabaea3aef8"
> >> +LIC_FILES_CHKSUM =
> >"file://LICENSE;md5=762a7ba8d2ddc3b38d88742fbaf0b62d"
> >
> >Please explain license change.
>
> The Copyright was updated from 2017 to 2017-2018 in LICENSE file.
In the commit log, please.
> >> -COMPATIBLE_MACHINE = "armv7a"
> >> +COMPATIBLE_MACHINE = "armv7a|aarch64"
> >>
> >> SRC_URI = " \
> >> git://github.com/ARM-software/ComputeLibrary.git;branch=${BRANCH}
> >> \
> >> + file://0001-add-ti-benchmark-test-group.patch \
> >> + file://0002-add-ti-benchmark-test-group.patch \
> >> + file://0003-add-ti-benchmark-test-group.patch \
> >> + file://0004-add-ti-benchmark-test-group.patch \
> >> + file://0005-add-ti-benchmark-test-group.patch \
> >> + file://0006-add-ti-benchmark-test-group.patch \
> >> + file://0007-add-ti-benchmark-test-group.patch \
> >> + file://0008-add-ti-benchmark-test-group.patch \
> >> + file://0009-add-ti-benchmark-test-group.patch \
> >> + file://0010-add-ti-benchmark-test-group.patch \
> >> + file://0011-add-ti-benchmark-test-group.patch \
> >> "
> >>
> >> -PV = "18.05"
> >> +PV = "18.08"
> >> +PV_MAJOR = "${@d.getVar('PV',d,1).split('.')[0]}"
> >>
> >> BRANCH = "master"
> >> -SRCREV = "e2542c9f35ca427286822cd0c9296f49914f78b0"
> >> +SRCREV = "52ba29e936b8e711e8acdfe819e36f884d4f3fe1"
> >>
> >> S = "${WORKDIR}/git"
> >>
> >> @@ -22,7 +34,8 @@ do_compile_prepend() {
> >>
> >> inherit scons
> >>
> >> -EXTRA_OESCONS = "arch=armv7a extra_cxx_flags="-fPIC"
> >benchmark_tests=1 validation_tests=0 neon=1 openmp=1 opencl=0"
> >> +EXTRA_OESCONS = "arch=armv7a extra_cxx_flags="-fPIC"
> >benchmark_tests=1 validation_tests=0 neon=1 openmp=1 opencl=0
> >set_soname=1"
> >> +EXTRA_OESCONS_aarch64 = "arch=arm64-v8a extra_cxx_flags="-fPIC"
> >benchmark_tests=1 validation_tests=0 neon=1 openmp=1 opencl=0
> >set_soname=1"
> >>
> >> LIBS += "-larmpl_lp64_mp"
> >>
> >> @@ -30,7 +43,7 @@ do_install() {
> >> CP_ARGS="-Prf --preserve=mode,timestamps --no-preserve=ownership"
> >>
> >> install -m 0755 -d ${D}${libdir}
> >> - for lib in ${S}/build/*.so
> >> + for lib in ${WORKDIR}/git/build/*.so*
> >
> >Why this change?
> >
>
> Unnecessary change, revised back in patch v2
>
> >
> >> do
> >> install -m 0755 $lib ${D}${libdir}
> >> done
> >> @@ -45,14 +58,11 @@ do_install() {
> >> cp $CP_ARGS ${S}/. ${D}${datadir}/${BPN} }
> >>
> >> -SOLIBS = ".so"
> >> -FILES_SOLIBSDEV = ""
> >> -INSANE_SKIP_${PN} = "ldflags"
> >> +INSANE_SKIP_${PN} = "ldflags dev-so"
> >
> >Since you now have "versioned library", you don't need to force *.so into the
> >main package.
> >
>
> Fixed in patch v2
>
> >
> >> INSANE_SKIP_${PN}-dev = "dev-elf ldflags"
> >>
> >> -PACKAGES =+ "${PN}-source"
> >> FILES_${PN} += "${bindir}/*"
> >> -FILES_${PN} += "${libdir}/*.so"
> >> +FILES_${PN} += "${libdir}/*.so*"
> >> FILES_${PN}-source = "${datadir}/${BPN}"
> >> INSANE_SKIP_${PN}-source = "ldflags libdir staticdev"
> >> INHIBIT_PACKAGE_DEBUG_SPLIT = "1"
> >> --
> >> 1.9.1
> >>
> >> _______________________________________________
> >> meta-arago mailing list
> >> meta-arago@arago-project.org
> >> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
_______________________________________________
meta-arago mailing list
meta-arago@arago-project.org
http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
