On Tue, Nov 27, 2018 at 03:00:22PM -0500, Su, Qin wrote:
>
>
> >-----Original Message-----
> >From: Dmytriyenko, Denys
> >Sent: Monday, November 26, 2018 5:12 PM
> >To: Su, Qin
> >Cc: meta-arago@arago-project.org
> >Subject: Re: [meta-arago] [PATCH v2] arm-compute-library: bump SRCREV and
> >add TI benchmark test group.
> >
> >On Wed, Nov 21, 2018 at 02:01:53PM -0500, Qin Su wrote:
> >> updated to the latest version of 18.08 updated LIC_FILES_CHKSUM as
> >> Copyright time changed in LICENSE from 2017 to 2017-2018 updated to
> >> generate versioned library added benchmark preset group for squeezenet
> >> and inceptionnet
> >
> >Mostly looks good. 2 comments re: permissions and *.so below.
[snip]
> >> @@ -30,7 +43,7 @@ do_install() {
> >> CP_ARGS="-Prf --preserve=mode,timestamps --no-preserve=ownership"
> >>
> >> install -m 0755 -d ${D}${libdir}
> >> - for lib in ${S}/build/*.so
> >> + for lib in ${S}/build/*.so*
> >> do
> >> install -m 0755 $lib ${D}${libdir}
> >> done
> >> @@ -43,16 +56,13 @@ do_install() {
> >> # Install built source package as expected by ARMNN
> >> install -d ${D}${datadir}/${BPN}
> >> cp $CP_ARGS ${S}/. ${D}${datadir}/${BPN}
> >> + # Remove unneeded symlink .so
> >> + rm -f ${D}${datadir}/${BPN}/build/*.so
> >
> >Why? They are useful for development and would automatically get packaged
> >into ${PN}-dev package...
> >
> These are the source files used by armnn. I did a clean up here with the
> change of
> enabling the use of shared library in armnn patch v3
>
> Replaced:
> # Install built source package as expected by ARMNN
> install -d ${D}${datadir}/${BPN}
> cp $CP_ARGS ${S}/. ${D}${datadir}/${BPN}
> # Remove unneeded symlink .so
> rm -f ${D}${datadir}/${BPN}/build/*.so
>
> with:
> # Install built source package as expected by ARMNN
> install -d ${D}${datadir}/${BPN}
> cp $CP_ARGS ${S}/arm_compute ${D}${datadir}/${BPN}/.
> cp $CP_ARGS ${S}/include ${D}${datadir}/${BPN}/.
> cp $CP_ARGS ${S}/support ${D}${datadir}/${BPN}/.
Ah, sorry, I misread your code above - you are correct, those are sources
installed into ${datadir}. Yes, the new code is more clear about that. Thanks!
> >> -SOLIBS = ".so"
> >> -FILES_SOLIBSDEV = ""
> >> INSANE_SKIP_${PN} = "ldflags"
> >> INSANE_SKIP_${PN}-dev = "dev-elf ldflags"
> >>
> >> -PACKAGES =+ "${PN}-source"
> >> -FILES_${PN} += "${bindir}/*"
> >> -FILES_${PN} += "${libdir}/*.so"
> >> FILES_${PN}-source = "${datadir}/${BPN}"
> >> INSANE_SKIP_${PN}-source = "ldflags libdir staticdev"
> >> INHIBIT_PACKAGE_DEBUG_SPLIT = "1"
> >> --
> >> 1.9.1
> >>
> >> _______________________________________________
> >> meta-arago mailing list
> >> meta-arago@arago-project.org
> >> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
_______________________________________________
meta-arago mailing list
meta-arago@arago-project.org
http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
