Yes, looks fine. Thanks.
On Fri, Mar 08, 2019 at 04:59:28PM -0500, Xu, Jianzhong wrote: > How about this commit message: > > tidl-utils: 1. update to add new features to TIDL import tool > - ONNX > - Tensorflow 1.7 and above > - linking with OpenCV for ARM build > 2. change license checksum by only calculating license header > in itidl_ti.h > since this file has changed and will likely change in > future. > > -----Original Message----- > From: Dmytriyenko, Denys > Sent: Friday, March 08, 2019 4:08 PM > To: Xu, Jianzhong > Cc: [email protected] > Subject: Re: [meta-arago] [PATCH v3] tidl-utils: add new features; change > license checksum > > The gold rule of every commit message is to answer the "Why?" question, not > "What?". The code change in the patch itself covers "What?", the commit > message should explain "Why?" - why those changes are being made? > > Let's see: > > add new features; > > Update to add new features, fine. > > > > change license checksum > > Yeah, the license checksum is being changed, but why? > > We've just gone through the same excercise with Mahesh, just on meta-ti list: > https://lists.yoctoproject.org/pipermail/meta-ti/2019-March/thread.html > > > On Fri, Mar 08, 2019 at 08:29:45AM -0500, Jianzhong Xu wrote: > > Signed-off-by: Jianzhong Xu <[email protected]> > > --- > > Change from previous version of patch: commit message modification > > --- > > meta-arago-extras/recipes-ti/tidl-utils/tidl-import_git.bb | 8 ++++---- > > meta-arago-extras/recipes-ti/tidl-utils/tidl-utils.bb | 2 +- > > meta-arago-extras/recipes-ti/tidl-utils/tidl-utils.inc | 2 +- > > 3 files changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/meta-arago-extras/recipes-ti/tidl-utils/tidl-import_git.bb > > b/meta-arago-extras/recipes-ti/tidl-utils/tidl-import_git.bb > > index 1291f9d..bef2d1a 100644 > > --- a/meta-arago-extras/recipes-ti/tidl-utils/tidl-import_git.bb > > +++ b/meta-arago-extras/recipes-ti/tidl-utils/tidl-import_git.bb > > @@ -5,10 +5,10 @@ DESCRIPTION = "TIDL import tool is using protobuf to read > > and parse information > > require ./tidl-utils.inc > > > > LICENSE = "BSD-3" > > -LIC_FILES_CHKSUM = > > "file://modules/ti_dl/inc/itidl_ti.h;md5=7baa68fec0aadbac92c3b41b283d26c4" > > +LIC_FILES_CHKSUM = > > "file://modules/ti_dl/inc/itidl_ti.h;beginline=1;endline=34;md5=cabe1fdaabfa0d85dc5544566b0e2425" > > > > -PV = "01.00.00.00" > > -PR = "r1" > > +PV = "01.01.00.00" > > +PR = "r0" > > > > S = "${WORKDIR}/git/src/importTool/" > > > > @@ -21,7 +21,7 @@ EXTRA_OEMAKE += "CORE=eve" > > EXTRA_OEMAKE += "TARGET_BUILD=release" > > EXTRA_OEMAKE += "TARGET_PLATFORM=PC" > > > > -EXTRA_MAKE_ARGS = "PLATFORM_BUILD=x86 LINUX_IMPORT_TOOL=64BIT > > PROTOBUF_LIB_DIR=${STAGING_DIR_NATIVE}/usr/lib > > PROTOBUF_INC_DIR=${STAGING_DIR_NATIVE}/usr/include" > > +EXTRA_MAKE_ARGS = "PLATFORM_BUILD=x86 LINUXENV=x86 LINUX_IMPORT_TOOL=64BIT > > PROTOBUF_LIB_DIR=${STAGING_DIR_NATIVE}/usr/lib > > PROTOBUF_INC_DIR=${STAGING_DIR_NATIVE}/usr/include" > > EXTRA_MAKE_ARGS_class-target = > > "LINUX_BUILD_TOOLS=${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX} > > PROTOBUF_LIB_DIR=${STAGING_LIBDIR} PROTOBUF_INC_DIR=${STAGING_INCDIR} > > LINUXENV=oearm" > > > > EXTRA_OEMAKE += "${EXTRA_MAKE_ARGS}" > > diff --git a/meta-arago-extras/recipes-ti/tidl-utils/tidl-utils.bb > > b/meta-arago-extras/recipes-ti/tidl-utils/tidl-utils.bb > > index e065e17..69b6e29 100644 > > --- a/meta-arago-extras/recipes-ti/tidl-utils/tidl-utils.bb > > +++ b/meta-arago-extras/recipes-ti/tidl-utils/tidl-utils.bb > > @@ -5,7 +5,7 @@ LICENSE = "TI-TFL" > > > > require ./tidl-utils.inc > > > > -PV = "1.0.0.1" > > +PV = "1.0.1.0" > > INC_PR = "r0" > > > > LIC_FILES_CHKSUM = > > "file://docs/LICENSE.txt;md5=a93aa5af7a3bbbb6fb34c8df59efaa5c" > > diff --git a/meta-arago-extras/recipes-ti/tidl-utils/tidl-utils.inc > > b/meta-arago-extras/recipes-ti/tidl-utils/tidl-utils.inc > > index 37ce84d..9ccabdd 100644 > > --- a/meta-arago-extras/recipes-ti/tidl-utils/tidl-utils.inc > > +++ b/meta-arago-extras/recipes-ti/tidl-utils/tidl-utils.inc > > @@ -1,2 +1,2 @@ > > SRC_URI = "git://git.ti.com/tidl/tidl-utils.git;protocol=git;branch=master" > > -SRCREV = "0021b6f15ee4a1a8919905429a5045fd02afe5b1" > > +SRCREV = "057984b05e143a4740ecec3dd28cfa082927b897" > > -- > > 1.9.1 > > > > _______________________________________________ > > meta-arago mailing list > > [email protected] > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago _______________________________________________ meta-arago mailing list [email protected] http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
