On 7/3/2019 3:41 PM, Denys Dmytriyenko wrote:
On Wed, Jul 03, 2019 at 01:46:37PM -0400, Jacob Stiffler wrote:
* When using the OE toolchain in the devkit, the sysroot option is
   required, so add this to the default CC in Rules.make
* Also, this does not have any negative impact when the external
   toolchain is packaged in the devkit.
* Update the fragments which break without the sysroot option.

See 31702588e02cdcf466b2b6f153ce9604e3cd105a

Signed-off-by: Jacob Stiffler <[email protected]>
---
  .../ti-tisdk-makefile/ti-tisdk-makefile/Makefile_am-sysinfo             | 2 +-
  .../ti-tisdk-makefile/ti-tisdk-makefile/Makefile_arm-benchmarks         | 2 +-
  .../ti-tisdk-makefile/ti-tisdk-makefile/Makefile_oprofile-example       | 2 +-
  .../recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Rules.make        | 2 +-
  .../recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile_1.0.bb            | 2 +-
  5 files changed, 5 insertions(+), 5 deletions(-)

diff --git 
a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Makefile_am-sysinfo
 
b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Makefile_am-sysinfo
index 445dd10..e198350 100644
--- 
a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Makefile_am-sysinfo
+++ 
b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Makefile_am-sysinfo
@@ -3,7 +3,7 @@ am-sysinfo:
        @echo =============================
        @echo    Building AM Sysinfo
        @echo =============================
-       @cd example-applications; cd `find . -name "*am-sysinfo*"`; make
+       @cd example-applications; cd `find . -name "*am-sysinfo*"`; make 
CC="$(CC)"
am-sysinfo_clean:
        @echo =============================
diff --git 
a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Makefile_arm-benchmarks
 
b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Makefile_arm-benchmarks
index 0447ea5..9a1f8aa 100644
--- 
a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Makefile_arm-benchmarks
+++ 
b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Makefile_arm-benchmarks
@@ -3,7 +3,7 @@ arm-benchmarks:
        @echo =============================
        @echo    Building ARM Benchmarks
        @echo =============================
-       @cd example-applications; cd `find . -name "*arm-benchmarks*"`; make
+       @cd example-applications; cd `find . -name "*arm-benchmarks*"`; make 
CC="$(CC)"
arm-benchmarks_clean:
        @echo =============================
diff --git 
a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Makefile_oprofile-example
 
b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Makefile_oprofile-example
index c7a4385..1e4793b 100644
--- 
a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Makefile_oprofile-example
+++ 
b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Makefile_oprofile-example
@@ -3,7 +3,7 @@ oprofile-example:
        @echo =============================
        @echo    Building OProfile Example
        @echo =============================
-       @cd example-applications; cd `find . -name "*oprofile-example*"`; make
+       @cd example-applications; cd `find . -name "*oprofile-example*"`; make 
CC="$(CC)"
oprofile-example_clean:
        @echo =============================
diff --git 
a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Rules.make
 
b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Rules.make
index fad8045..bfee2fc 100644
--- 
a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Rules.make
+++ 
b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Rules.make
@@ -25,7 +25,7 @@ export 
CROSS_COMPILE=$(LINUX_DEVKIT_PATH)/sysroots/__SDKMACHINE__-arago-linux/us
#Default CC value to be used when cross compiling. This is so that the
  #GNU Make default of "cc" is not used to point to the host compiler
-export CC=$(CROSS_COMPILE)gcc
+export CC=$(CROSS_COMPILE)gcc --sysroot=$(SDK_PATH_TARGET)
I see you overwrite CC here - do you use environment-setup script?


Some targets do, some do not.


  #Location of environment-setup file
  export ENV_SETUP=$(LINUX_DEVKIT_PATH)/environment-setup
And it's listed here. Shouldn't CC come from this script instead?

BTW, defining just CC may not be enough for some cases - CPP, CXX, LD, etc.
are also needed and set in there. I wonder if there's too much customization
going on in the tisdk-makefile...


Yeah, there is a long history here. Originally, I don't think any targets were using the environment-setup script.



diff --git 
a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile_1.0.bb 
b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile_1.0.bb
index 87f7150..9131a71 100644
--- a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile_1.0.bb
+++ b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile_1.0.bb
@@ -54,7 +54,7 @@ SRC_URI = "\
      file://Makefile_pdm-anomaly-detection \
  "
-PR = "r96"
+PR = "r97"
MAKEFILES_MATRIX_GUI = "matrix-gui-browser \
                          refresh-screen \
--
2.7.4

_______________________________________________
meta-arago mailing list
[email protected]
http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
_______________________________________________
meta-arago mailing list
[email protected]
http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago

Reply via email to