On Thu, Oct 29, 2020 at 11:36:45AM -0500, Dan Murphy wrote: > Nikhil > > On 10/28/20 6:27 PM, Denys Dmytriyenko wrote: > >From: Nikhil Devshatwar <[email protected]> > > > >websocketd is an application which allows to redirect output of > >command line applications via a websocket so that web pages can > >interact with them. > > > >This is very useful for visualizing statistics information on > >host machine browser. > > > >Signed-off-by: Nikhil Devshatwar <[email protected]> > >Signed-off-by: Denys Dmytriyenko <[email protected]> > >--- > >v4 - export http_proxy with explanation > > > > .../recipes-devtools/websocketd/websocketd_0.3.1.bb | 18 > > ++++++++++++++++++ > > 1 file changed, 18 insertions(+) > > create mode 100644 > > meta-arago-extras/recipes-devtools/websocketd/websocketd_0.3.1.bb > > > >diff --git > >a/meta-arago-extras/recipes-devtools/websocketd/websocketd_0.3.1.bb > >b/meta-arago-extras/recipes-devtools/websocketd/websocketd_0.3.1.bb > >new file mode 100644 > >index 0000000..d2f3387 > >--- /dev/null > >+++ b/meta-arago-extras/recipes-devtools/websocketd/websocketd_0.3.1.bb > >@@ -0,0 +1,18 @@ > >+SUMMARY = "Application for routing native applications via websockets" > >+HOMEPAGE = "http://websocketd.com/"; > >+LICENSE = "BSD-2-Clause" > >+LIC_FILES_CHKSUM = > >"file://src/${GO_IMPORT}/LICENSE;md5=a14d7befdbee1290ac5c472cd85d66f2" > >+ > >+inherit go-mod > >+ > >+GO_IMPORT = "github.com/joewalnes/websocketd" > >+ > >+SRC_URI = "git://${GO_IMPORT}" > >+SRCREV = "0440211d7862dc76b5f2499d7dfcd4ef6a9c2fa2" > >+ > >+# bitbake only exports proxy variables during fetching, but go handles > >+# module fetching on its own during compile and needs proxy settings > >+export http_proxy > >+ > >+# Development package contains all the examples in different languages > >+INSANE_SKIP_${PN}-dev = "file-rdeps" > > This looks fine to me but I think we should add the version we are checking > out. > > I mean this repo has not been updated in years but we should add the version > so we know it is v0.3.1.
SRCREV above corresponds to v0.3.1 tag. While you could use the tag directly, it's not recommended and it's better to use specific commit SHA directly in the recipes, even if it's the same as the tag. The only benefit of using the tag in SRCREV is developer convenience. There are several drawbacks though: * tag could move, so someone else using your recipe could get a completely different output, not what you expected or intended * tag needs to be resolved against the origin git server on every bitbake parse, regardless if you have local sources cached or stored on a mirror. That requires network connection, proxies setup, etc. for every time you run bitbake. And some customers require isolated no-network builds when all the sources are available locally * and from integration/release perspective there's less control of the build and results due to the above - images, packages, sstate could change. Not an issue for nightly builds, but could be a major issue for reproducible releases -- Denys _______________________________________________ meta-arago mailing list [email protected] http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
