On Thu, 12 Nov 2020 at 20:20, Tammana, Gowtham <[email protected]> wrote: > > > > >-----Original Message----- > >From: Paul Barker <[email protected]> > >Sent: Thursday, November 12, 2020 12:28 PM > >To: Tammana, Gowtham <[email protected]> > >Cc: [email protected] > >Subject: Re: [EXTERNAL] [meta-arago] [master/dunfell PATCH] matrix-gui-pm- > >demos: Allow empty package > > > >On Thu, 12 Nov 2020 at 17:42, Tammana, Gowtham <[email protected]> wrote: > >> > >> > >> > >> >-----Original Message----- > >> >From: Paul Barker <[email protected]> > >> >Sent: Wednesday, November 11, 2020 10:56 AM > >> >To: Tammana, Gowtham <[email protected]> > >> >Cc: [email protected] > >> >Subject: Re: [EXTERNAL] [meta-arago] [master/dunfell PATCH] matrix-gui- > >pm- > >> >demos: Allow empty package > >> > > >> >On Fri, 6 Nov 2020 at 22:45, Tammana, Gowtham <[email protected]> wrote: > >> >> > >> >> > >> >> > >> >> >-----Original Message----- > >> >> >From: Paul Barker <[email protected]> > >> >> >Sent: Friday, November 06, 2020 3:06 AM > >> >> >To: Tammana, Gowtham <[email protected]> > >> >> >Cc: [email protected] > >> >> >Subject: Re: [EXTERNAL] [meta-arago] [master/dunfell PATCH] matrix- > >gui- > >> >pm- > >> >> >demos: Allow empty package > >> >> > > >> >> >On Thu, 5 Nov 2020 at 22:54, Tammana, Gowtham <[email protected]> > >wrote: > >> >> >> > >> >> >> >-----Original Message----- > >> >> >> >From: [email protected] <meta-arago- > >> >bounces@arago- > >> >> >> >project.org> On Behalf Of Paul Barker > >> >> >> >Sent: Thursday, November 05, 2020 4:38 AM > >> >> >> >To: [email protected] > >> >> >> >Subject: [EXTERNAL] [meta-arago] [master/dunfell PATCH] matrix- > >gui- > >> >pm- > >> >> >> >demos: Allow empty package > >> >> >> > > >> >> >> >The matrix-gui-pm-demos recipe splits its binaries into several > >> >> >> >subpackages leaving the default package empty. The dependencies > >for > >> >the > >> >> >> >default package are set so it makes sense to allow this empty > >> >package > >> >> >to > >> >> >> >be created. > >> >> >> > > >> >> >> >Signed-off-by: Paul Barker <[email protected]> > >> >> >> >--- > >> >> >> > meta-arago-extras/recipes-core/matrix/matrix-gui-pm-demos_2.0.bb > >| > >> >1 + > >> >> >> > 1 file changed, 1 insertion(+) > >> >> >> > > >> >> >> >diff --git a/meta-arago-extras/recipes-core/matrix/matrix-gui-pm- > >> >> >> >demos_2.0.bb b/meta-arago-extras/recipes-core/matrix/matrix-gui- > >pm- > >> >> >> >demos_2.0.bb > >> >> >> >index 0116f5ea..a9ebb84f 100644 > >> >> >> >--- a/meta-arago-extras/recipes-core/matrix/matrix-gui-pm- > >> >demos_2.0.bb > >> >> >> >+++ b/meta-arago-extras/recipes-core/matrix/matrix-gui-pm- > >> >demos_2.0.bb > >> >> >> >@@ -10,6 +10,7 @@ S = "${WORKDIR}/git/power_apps" > >> >> >> > > >> >> >> > # Make sure power submenu and app images has been installed > >> >> >> > RDEPENDS_${PN} += "matrix-gui-apps-images matrix-gui-submenus- > >power > >> >> >> >matrix-gui-generic-pm" > >> >> >> >+ALLOW_EMPTY_${PN} = "1" > >> >> >> > >> >> >> Just curious, I assume that the deployment of the dependent > >packages > >> >is > >> >> >still > >> >> >> ensured even without this change. This just makes it apparent to > >the > >> >> >user that > >> >> >> the default package is empty. Or is it that the deployment of > >> >dependent > >> >> >packages > >> >> >> is broken without this. > >> >> > > >> >> >Without this change the matrix-gui-pm-demos package is not created > >and > >> >> >cannot be installed. > >> >> > >> >> Yes, but as the package here is empty trying to understand why it > >needs > >> >to > >> >> be installed in the first place. > >> >> > >> >> Now that the package is created, wondering if the dependencies with > >the > >> >> sub-packages needs to be listed as well something like > >> >> > >> >> RDEPENDS_${PN} += ${PN}-<subpackages} or > >> >> > >> >> RDEPENDS_${PN}-<subpackages> = ${PN} > >> > > >> >I'm not sure I understand your comment here. RDEPENDS_${PN} is set on > >> >the line above my change. So effectively ${PN} is a packagegroup which > >> >will install the listed dependencies. But without ALLOW_EMPTY being > >> >set it won't be created. > >> > > >> >The other thing to consider is that ${PN} is a default dependency of > >> >${PN}-dev and so not creating a ${PN} package can result in image > >> >features like dev-pkgs breaking. > >> > >> The comment was for the dependencies for the sub-packages ${PN}-count > >> and others here. I don't think ${PN} becomes a default dependency for > >> sub-packages. Atleast the `opkg install` on sub-packages is not checking > >> on the ${PN} dependencies. Given they are dependencies I reasoned that > >> they can be added to the sub-packages with > >> > >> RDEPENDS-${PN}-count += ${PN} > >> > >> so that ${PN} listed dependencies are installed on installation of any of > >> the sub-package which seems to be what the recipe wants. > >> > >> I see that this patch has been merged. This can be a separate patch. I > >> can push this change if you would like me to. > > > >I guess you are describing a different issue here. Are the > >dependencies listed in RDEPENDS_${PN} supposed to apply to the > >subpackages? > > I think they are here.
Ok. That's completely outside my area of knowledge here so I think you'll have to send a patch yourself for that. -- Paul Barker Konsulko Group _______________________________________________ meta-arago mailing list [email protected] http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
