On Thu, Mar 11, 2021 at 01:15:37AM +0530, Nikhil Devshatwar wrote:
>
>
> On 11/03/21 12:20 am, Bajjuri, Praneeth wrote:
> >
> >
> >On 3/10/2021 12:37 PM, Nikhil Devshatwar wrote:
> >>
> >>
> >>On 10/03/21 11:00 pm, Bajjuri, Praneeth wrote:
> >>>
> >>>
> >>>On 3/3/2021 12:21 PM, Nikhil Devshatwar wrote:
> >>>>Currently, the K3 platforms do not include the TI wlan
> >>>>related packages.
> >>>>Add in the tisdk-connectivity packagegroup.
> >>>>
> >>>>Signed-off-by: Nikhil Devshatwar <[email protected]>
> >>>>Suggested-by: Hari Nagalla <[email protected]>
> >>>>Reviewed-by: Lokesh Vutla <[email protected]>
> >>>>---
> >>>>
> >>>>Notes:
> >>>> changes from v1:
> >>>
> >>>s/meta-ti/meta-arago. Please point to right project next time.
> >>Sorry about that. Reused last command and missed this.
> >>
> >>>
> >>>> * Drop the new recipe and simply include the existing
> >>>>packages for wilink
> >>>> This way, all the platforms are using the same
> >>>>recipes and we don't
> >>>> have to maintain any new recipe just for the am64xx-sk
> >>>> The firmare will get picked from the repo
> >>>> git://git.ti.com/wilink8-wlan/wl18xx_fw.git
> >>>>
> >>>>
> >>>>.../packagegroups/packagegroup-arago-tisdk-connectivity.bb
> >>>>| 1 +
> >>>> 1 file changed, 1 insertion(+)
> >>>>
> >>>>diff --git
> >>>>a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-connectivity.bb
> >>>>
> >>>>b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-connectivity.bb
> >>>>
> >>>>index 11109432..ab632924 100644
> >>>>---
> >>>>a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-connectivity.bb
> >>>>
> >>>>+++
> >>>>b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-connectivity.bb
> >>>>
> >>>>@@ -89,6 +89,7 @@ CONNECTIVITY_RDEPENDS_append_dra7xx = "\
> >>>> CONNECTIVITY_RDEPENDS_append_k3 = "\
> >>>> ${WLAN_COMMON} \
> >>>> ${BT_COMMON} \
> >>>>+ ${WLAN_TI} \
> >>>> "
> >>>
> >>>Looks like WLAN_TI and WLAN_COMMON is valid for all platforms
> >>>defined in this packagegroup.
> >>>
> >>>why not move both of them under CONNECTIVITY_RDEPENDS without
> >>>a specific platform append?.
> >>
> >>Looking at the history, the following commit split the package
> >>list into a separate group explicitly:
> >>
> >>d24fa63f33 ("packagegroup-*-connectivity: restructure WLAN & BT
> >>lists and add WLAN to K3")
> >>
> >>Where the WLAN_COMMON was added but WLAN_TI was not added.
> >
> >Thats correct, But after this patch we have WLAN_TI and
> >WLAN_COMMON for all platforms now (including K3).
> >
> >Why not do something like this.
>
> I am not sure why the packages are split in the first place.
> If you want it like this, I will send a v3
Because at some point not all platforms supported WiFi and/or BT.
Denys
> >@@ -61,36 +61,25 @@ CONNECTIVITY_RDEPENDS = " \
> > iproute2-devlink \
> > net-snmp \
> > net-snmp-server-snmpd \
> >-"
> >-
> >-CONNECTIVITY_RDEPENDS_append_ti33x = "\
> > ${WLAN_COMMON} \
> > ${WLAN_TI} \
> > ${BT_COMMON} \
> >+"
> >+
> >+CONNECTIVITY_RDEPENDS_append_ti33x = "\
> > ${BT_TI} \
> > ${DEMO_APPS} \
> > "
> >
> > CONNECTIVITY_RDEPENDS_append_ti43x = "\
> >- ${WLAN_COMMON} \
> >- ${WLAN_TI} \
> >- ${BT_COMMON} \
> > ${BT_TI} \
> > ${DEMO_APPS} \
> > "
> >
> > CONNECTIVITY_RDEPENDS_append_dra7xx = "\
> >- ${WLAN_COMMON} \
> >- ${WLAN_TI} \
> >- ${BT_COMMON} \
> > ${BT_TI} \
> > "
> >
> >-CONNECTIVITY_RDEPENDS_append_k3 = "\
> >- ${WLAN_COMMON} \
> >- ${BT_COMMON} \
> >-"
> >-
> >
> >
> >
> >>
> >>Regards,
> >>Nikhil D
> >>>
> >>>> RDEPENDS_${PN} = "\
> >>>>
_______________________________________________
meta-arago mailing list
[email protected]
http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
