On Wed, Jan 04, 2023 at 04:15:44PM -0600, Andrew Davis via lists.yoctoproject.org wrote: > On 1/4/23 3:07 PM, Denys Dmytriyenko wrote: > >On Wed, Jan 04, 2023 at 01:07:39PM -0600, Andrew Davis via > >lists.yoctoproject.org wrote: > >>To match upstream oe-core/master. > >> > >>Signed-off-by: Andrew Davis <[email protected]> > >>--- > >> ...equire-GL_EXT_unpack_subimage-commit.patch | 91 +++++++++++++++++++ > >> ...ct-plane-based-on-current-attached-C.patch | 52 +++++------ > >> ..._9.0.0.bbappend => weston_10.0.2.bbappend} | 3 +- > >> 3 files changed, 115 insertions(+), 31 deletions(-) > >> create mode 100644 > >> meta-arago-distro/recipes-graphics/wayland/weston/0001-Revert-require-GL_EXT_unpack_subimage-commit.patch > >> rename meta-arago-distro/recipes-graphics/wayland/{weston_9.0.0.bbappend > >> => weston_10.0.2.bbappend} (78%) > >> > >>diff --git > >>a/meta-arago-distro/recipes-graphics/wayland/weston/0001-Revert-require-GL_EXT_unpack_subimage-commit.patch > >> > >>b/meta-arago-distro/recipes-graphics/wayland/weston/0001-Revert-require-GL_EXT_unpack_subimage-commit.patch > >>new file mode 100644 > >>index 00000000..8bc882fb > >>--- /dev/null > >>+++ > >>b/meta-arago-distro/recipes-graphics/wayland/weston/0001-Revert-require-GL_EXT_unpack_subimage-commit.patch > >>@@ -0,0 +1,91 @@ > >>+From 6558a9153cc81199146132041c61023a2c2e1b2e Mon Sep 17 00:00:00 2001 > >>+From: Andrew Davis <[email protected]> > >>+Date: Thu, 6 Oct 2022 15:49:31 -0500 > >>+Subject: [PATCH] Revert require GL_EXT_unpack_subimage commit > >>+ > >>+This reverts commit 593d5af43a8e2c2a3371088fa7ae430d0517c82d. > >>+ > >>+That commit removed support for GPU drivers without GL_EXT_unpack_subimage > >>+which SGX does not support. Add back support for GPUs without this > >>+extension. > > > >The obvious question - how safe is it to assume GL_EXT_unpack_subimage is > >not being used some place else outside of this commit and not guarded by: > > > >if (!gr->has_unpack_subimage) > > > > > >Is this extention really in the driver, or just in a Mesa API translation > >layer? Could it be better fixed in the DDK? > > > > You are right, it is not a very safe assumption, this patch is almost > certainly > not complete for all cases. And even if it was, it only fixes Weston, others > like > wlroots have the same issues[0], so other compositors are going to be broken > too. > > Long term this extension will need added to the driver. Unfortunately all > work on > keeping this driver alive is unofficial, and I just don't have the free time > to > add and test new extensions right now :( > > Andrew > > [0] > https://github.com/tmlind/wlroots/commit/04491889240bbadb693aa37036dc55835118b2cc
Ryan, I see you are pulling this patch to the WIP branches - what's the consensus here? As discussed, this is a very partial solution. Moreover, it only "fixes" meta-arago, so won't help people using just meta-ti with other distros... -- Denys -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#14172): https://lists.yoctoproject.org/g/meta-arago/message/14172 Mute This Topic: https://lists.yoctoproject.org/mt/96057194/21656 Group Owner: [email protected] Unsubscribe: https://lists.yoctoproject.org/g/meta-arago/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
