Hi Daiane, On Tue, 12 Nov 2013 09:21:26 -0200 Daiane Angolini <[email protected]> wrote:
> On Mon, Nov 11, 2013 at 2:44 PM, Mario Domenech Goulart > <[email protected]> wrote: >> Common settings for wandboard-quad, wandboard-dual and wandboard-solo. > > What? > > I like you patch, but I think you can improve this commit log/subject. I'm gonna submit the patches again, since I created them against dora by mistake. While at it, I'll improve the commit message. Best wishes. Mario > > > Daiane > >> >> Signed-off-by: Mario Domenech Goulart <[email protected]> >> --- >> conf/machine/include/wandboard.inc | 10 ++++++++++ >> conf/machine/wandboard-dual.conf | 9 ++------- >> conf/machine/wandboard-quad.conf | 9 ++------- >> conf/machine/wandboard-solo.conf | 9 +-------- >> 4 files changed, 15 insertions(+), 22 deletions(-) >> create mode 100644 conf/machine/include/wandboard.inc >> >> diff --git a/conf/machine/include/wandboard.inc >> b/conf/machine/include/wandboard.inc >> new file mode 100644 >> index 0000000..a304b11 >> --- /dev/null >> +++ b/conf/machine/include/wandboard.inc >> @@ -0,0 +1,10 @@ >> +# Common settings for wandboard boards >> + >> +include conf/machine/include/imx-base.inc >> +include conf/machine/include/tune-cortexa9.inc >> + >> +PREFERRED_PROVIDER_virtual/kernel = "linux-wandboard" >> + >> +SERIAL_CONSOLE = "115200 ttymxc0" >> + >> +MACHINE_FEATURES += "pci wifi" >> diff --git a/conf/machine/wandboard-dual.conf >> b/conf/machine/wandboard-dual.conf >> index eaee17b..1821192 100644 >> --- a/conf/machine/wandboard-dual.conf >> +++ b/conf/machine/wandboard-dual.conf >> @@ -3,19 +3,14 @@ >> #@SOC: i.MX6DL >> #@DESCRIPTION: Machine configuration for i.MX6 Wandboard Duallite >> >> -include conf/machine/include/imx-base.inc >> -include conf/machine/include/tune-cortexa9.inc >> +include include/wandboard.inc >> >> SOC_FAMILY = "mx6:mx6dl:wandboard" >> >> -PREFERRED_PROVIDER_virtual/kernel = "linux-wandboard" >> - >> UBOOT_MACHINE = "wandboard_dl_config" >> >> KERNEL_DEVICETREE = "imx6dl-wandboard.dtb" >> >> -SERIAL_CONSOLE = "115200 ttymxc0" >> - >> -MACHINE_FEATURES += " pci wifi bluetooth" >> +MACHINE_FEATURES += "bluetooth" >> >> MACHINE_EXTRA_RRECOMMENDS += " broadcom-nvram-config" >> diff --git a/conf/machine/wandboard-quad.conf >> b/conf/machine/wandboard-quad.conf >> index 4f32590..195a69f 100644 >> --- a/conf/machine/wandboard-quad.conf >> +++ b/conf/machine/wandboard-quad.conf >> @@ -3,19 +3,14 @@ >> #@SOC: i.MX6Q >> #@DESCRIPTION: Machine configuration for i.MX6 Wandboard Quad >> >> -include conf/machine/include/imx-base.inc >> -include conf/machine/include/tune-cortexa9.inc >> +include include/wandboard.inc >> >> SOC_FAMILY = "mx6:mx6q:wandboard" >> >> -PREFERRED_PROVIDER_virtual/kernel = "linux-wandboard" >> - >> UBOOT_MACHINE = "wandboard_quad_config" >> >> KERNEL_DEVICETREE = "imx6q-wandboard.dtb" >> >> -SERIAL_CONSOLE = "115200 ttymxc0" >> - >> -MACHINE_FEATURES += " pci wifi bluetooth" >> +MACHINE_FEATURES += "bluetooth" >> >> MACHINE_EXTRA_RRECOMMENDS += " broadcom-nvram-config" >> diff --git a/conf/machine/wandboard-solo.conf >> b/conf/machine/wandboard-solo.conf >> index 970e650..9696aeb 100644 >> --- a/conf/machine/wandboard-solo.conf >> +++ b/conf/machine/wandboard-solo.conf >> @@ -3,17 +3,10 @@ >> #@SOC: i.MX6S >> #@DESCRIPTION: Machine configuration for i.MX6 Wandboard Solo >> >> -include conf/machine/include/imx-base.inc >> -include conf/machine/include/tune-cortexa9.inc >> +include include/wandboard.inc >> >> SOC_FAMILY = "mx6:mx6s:wandboard" >> >> -PREFERRED_PROVIDER_virtual/kernel = "linux-wandboard" >> - >> UBOOT_MACHINE = "wandboard_solo_config" >> >> KERNEL_DEVICETREE = "imx6dl-wandboard.dtb" >> - >> -SERIAL_CONSOLE = "115200 ttymxc0" >> - >> -MACHINE_FEATURES += " pci wifi" >> -- >> 1.7.10.4 >> >> _______________________________________________ >> meta-freescale mailing list >> [email protected] >> https://lists.yoctoproject.org/listinfo/meta-freescale > _______________________________________________ meta-freescale mailing list [email protected] https://lists.yoctoproject.org/listinfo/meta-freescale
