> -----Original Message----- > From: [email protected] [mailto:meta-freescale- > [email protected]] On Behalf Of Otavio Salvador > Sent: Monday, February 24, 2014 9:10 AM > To: meta-freescale Mailing List > Cc: Otavio Salvador > Subject: [meta-freescale] [meta-fsl-arm][PATCH 2/3] libmcc: Rework recipe > > - Use summary as the description was short > - Drop vendor name from summary > - Put RDEPENDS after source fields > - Add empty line between S and CFLAGS > - Drop extra space in CFLAGS appending
It took me more than 5 seconds to realize what this patch does. I think you can improve this commit subject and commit log with something like: "libmcc: Add minor changes to get recipe in better shape" And "In order to use the same pattern from other recipes, the following changes were made in recipe: > - Use summary as the description was short > - Drop vendor name from summary > - Put RDEPENDS after source fields > - Add empty line between S and CFLAGS > - Drop extra space in CFLAGS appending " Daiane > > Change-Id: Iadf4b9e8dee308692925cf7e0b22df9b4cffb03a > Signed-off-by: Otavio Salvador <[email protected]> > --- > recipes-bsp/libmcc/libmcc_1.04.bb | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/recipes-bsp/libmcc/libmcc_1.04.bb b/recipes- > bsp/libmcc/libmcc_1.04.bb > index 729a9b1..35efd45 100644 > --- a/recipes-bsp/libmcc/libmcc_1.04.bb > +++ b/recipes-bsp/libmcc/libmcc_1.04.bb > @@ -1,11 +1,9 @@ > # Copyright (C) 2013 Timesys Corporation -SUMMARY = "MCC Userspace > Library" > -DESCRIPTION = "Timesys Multicore communication Library" > +SUMMARY = "Multicore communication Library" > LICENSE = "GPL-2.0" > LIC_FILES_CHKSUM = "file://LICENSE;md5=c49712341497d0b5f2e40c30dff2af9d" > > DEPENDS = "kernel-module-mcc" > -RDEPENDS_${PN} = "kernel-module-mcc" > > inherit autotools > > @@ -15,6 +13,9 @@ SRC_URI[md5sum] = "e93ce76b4419f0902a848e1769bf22ea" > SRC_URI[sha256sum] = > "3de76c5b1a096021afebfc79ca4e85d05646beb3101edcecf73b82886e7a00c0" > > S = "${WORKDIR}/libmcc-${PV}" > -CFLAGS += " -I${STAGING_KERNEL_DIR}/include" > + > +CFLAGS += "-I${STAGING_KERNEL_DIR}/include" > + > +RDEPENDS_${PN} = "kernel-module-mcc" > > COMPATIBLE_MACHINE = "(vf60)" > -- > 1.9.0 > > _______________________________________________ > meta-freescale mailing list > [email protected] > https://lists.yoctoproject.org/listinfo/meta-freescale > _______________________________________________ meta-freescale mailing list [email protected] https://lists.yoctoproject.org/listinfo/meta-freescale
