On Thu, Apr 24, 2014 at 12:09 PM, Lauren Post <[email protected]>wrote:
> Change-Id: I9ead6170ff5e20be0405d6f162c9f047bb3f8d2a > Signed-off-by: Lauren Post <[email protected]> > > --- > recipes-multimedia/gstreamer/gst-fsl-plugin.inc | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/recipes-multimedia/gstreamer/gst-fsl-plugin.inc > b/recipes-multimedia/gstreamer/gst-fsl-plugin.inc > index 46bc6f0..4835b75 100644 > --- a/recipes-multimedia/gstreamer/gst-fsl-plugin.inc > +++ b/recipes-multimedia/gstreamer/gst-fsl-plugin.inc > @@ -26,7 +26,7 @@ PLATFORM_mx6sl = "MX6SL" > PLATFORM_mx28 = "MX28" > > # Todo add a mechanism to map posible build targets > -EXTRA_OECONF = "PLATFORM=${PLATFORM} \ > +EXTRA_OECONF = "PLATFORM=${PLATFORM} \ > This is a spurious change, I think it is a whitespace change, please revert this hunk. > CPPFLAGS="-I${STAGING_KERNEL_DIR}/include/uapi > -I${STAGING_KERNEL_DIR}/include"" > > PACKAGES =+ "${PN}-libmfwsconf ${PN}-libgplaycore ${PN}-libgstfsl \ > @@ -36,6 +36,12 @@ PACKAGES =+ "${PN}-libmfwsconf ${PN}-libgplaycore > ${PN}-libgstfsl \ > # FIXME: Add all features > # feature from excluded mm packages > PACKAGECONFIG[ac3] += > "--enable-ac3dec,--disable-ac3dec,libfslac3codec,libfslac3codec" > +# The ddplus codec does not support mx28 > +DDPDEPENDS = "libfslddpcodec" > +DDPDEPENDS_mx28 = "" > +DDP_CONFIG_ARGS = "--enable-ddpdec" > +DDP_CONFIG_ARGS_mx28 = "--disable-ddpdec" > +PACKAGECONFIG[ddp] += > "${DDP_CONFIG_ARGS},--disable-ddpdec,${DDPDEPENDS},${DDPDEPENDS}" > # feature from special mm packages > PACKAGECONFIG[aacp] += > "--enable-aacpdec,--disable-aacpdec,libfslaacpcodec,libfslaacpcodec" > MSDEPENDS = "libfslmsparser libfslmscodec" > This is wrong. PACKAGECONFIG first parameter is to be given /when/ the feature is enabled. So giving a --disable-ddpdec is conceptually wrong. Please use as: # ddp should not be enabled in MX23/MX28 PACKAGECONFIG[ddp] += "--enable-ddpdec,--disable-ddpdec,libfslddpcodec,libfslddpcodec" as this is much easier to read and does not use the PACKAGECONFIG mechanism in a not intended way. -- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
-- _______________________________________________ meta-freescale mailing list [email protected] https://lists.yoctoproject.org/listinfo/meta-freescale
