On Thu, Apr 9, 2015 at 8:45 AM, Daiane Angolini <[email protected]> wrote: > On Thu, Apr 9, 2015 at 4:05 AM, Valentin Raevsky > <[email protected]> wrote: >> Add cm-fx6 machine configuration: u-boot and kernel. > > Please, add more information on the machine description, maybe a URL > pointing to some place where I could see a board picture, and hardware > description. > > I prefer if you could change the commit subject and use something like: > > "cm-fx6: Add cm-x6 machine configuration" > > You can use as an example this commit: > https://github.com/Freescale/meta-fsl-arm-extra/commit/5fadb641dffe91ec9dedafcb1e27add3e45255dc > > >> >> Signed-off-by: Valentin Raevsky <[email protected]> >> --- >> conf/machine/cm-fx6.conf | 26 ++++++++++++++++++++++++++ >> 1 file changed, 26 insertions(+) >> create mode 100644 conf/machine/cm-fx6.conf >> >> diff --git a/conf/machine/cm-fx6.conf b/conf/machine/cm-fx6.conf >> new file mode 100644 >> index 0000000..2e0afdf >> --- /dev/null >> +++ b/conf/machine/cm-fx6.conf >> @@ -0,0 +1,26 @@ >> +#@TYPE: Machine >> +#@NAME: CompuLab CM-FX6 >> +#@SOC: i.MX6 Q/DL >> +#@DESCRIPTION: Machine configuration for CompuLab CM-FX6 machines >> +#@MAINTAINER: Valentin Raevsky <[email protected]> >> + >> +# require conf/machine/include/imx-base.inc > > Can you, please double check this line? > > I would follow the BSP layer standard, however I would accept not > using imx-base.inc with a good argument.
Don't use imx-base.inc is not acceptable. It will impose a lot of duplication and not use most SoC specific settings. Please Valentin use imx-base.inc as it includes the common and base settings across all i.MX platforms. -- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 -- _______________________________________________ meta-freescale mailing list [email protected] https://lists.yoctoproject.org/listinfo/meta-freescale
