On Wed, May 27, 2015 at 4:28 PM, Khem Raj <[email protected]> wrote: > >> On May 27, 2015, at 12:18 PM, Daiane Angolini <[email protected]> wrote: >> >> On Wed, May 27, 2015 at 4:08 PM, Khem Raj <[email protected]> wrote: >>> >>>> On May 27, 2015, at 11:48 AM, Daiane Angolini <[email protected]> >>>> wrote: >>>> >>>> On Wed, May 27, 2015 at 3:17 PM, Otavio Salvador >>>> <[email protected]> wrote: >>>>> On Wed, May 27, 2015 at 12:33 PM, Khem Raj <[email protected]> wrote: >>>>>> These SoCs are capable of thmub2 ISA as well as VFP >>>>>> unit is available on them. This patch makes the default >>>>>> tunes aware of that. The final ISA still remains as it is currently but >>>>>> it offers a choice to distros to choose an alternative thumb2 or a mix >>>>>> if they want to. >>>>>> >>>>>> Signed-off-by: Khem Raj <[email protected]> >>>>> >>>>> Your patch seems nicer; it would be good though if you could add the >>>>> discussion link included at: >>>>> >>>>> http://patchwork.openembedded.org/patch/94025/ >>>> >>>> And please, improve your commit log a little bit. I think it's confusing. >>>> >>>> "These SoCs are capable of thmub2 ISA as well as VFP >>>> unit is available on them. This patch makes the default >>>> tunes aware of that. The final ISA still remains as it is currently but >>>> it offers a choice to distros to choose an alternative thumb2 or a mix >>>> if they want to." >>>> >>>> Instead of "these socs" please say "The mx6 SoCs” >>> >>> sure >>> >>>> >>>> typo thmub2 -> thumb2 >>> >>> yes >>> >>>> >>>> soc are capable of thumb2 and VFP unit is available? >>>> >>>> "The final ISA still remains as it is currently" >>>> What does it means? The default for ISA is the same? >>> >>> It means that code generation still remains as it was before unless thumb2 >>> is chosen >>> explicitly. >> >> You turn, and turn, and turn only to say "nothing changed". I'm sorry, >> but it is confusing to me. > > Precisely, and its important to state that we are enabling knobs to turn on > additional capabilities > but default remains same. Whats so confusing about that ? > >> >>> >>>> >>>> And please, avoid choice and choose in the same sentence. And I'm not >>>> sure what you mean by "thumb2 or a mix, if they want to" (who is they? >>>> distros doesn't make choices ) >>> >>> what ? Distro make choices about default ISA before the machines, they got >>> to choose from the options that are offered by a machine. >>> >> >> People make choices. Distro can be configured, can override, can a lot >> of thing, not make a choice. Please, don't personify >> distro =P > > This is a commit message not a document where I would agree that a bit better > use of english language may > be required.
I completely disagree. Commit log is the only documentation we have <3 I'm sure your v2 commit log is going to be much better Daiane > >> >> But it's not very important, try only to not say chose the choice. >> choice the option is nicer >> >> >>>> >>>> Maybe something like: >>>> >>>> " >>>> mx6 SoC can be used with both thumb2 ISA or VFP enabled. >>>> >>>> Change the default tunes in order to enable both always. >>>> >>>> In addition, it offers more options to external distros. >>>> “ >>> >>> its a machine layer so all distros are external to it. >> >> Yes, you are right. >> >> >> Daiane >> >>> >>>> >>>> At least it was what I understood from your commit log. This way you >>>> can double check if my understanding is what you meant. >>>> >>> >>> Thanks for your feedback, I will send a v2 shortly. >>> >>>> >>>> Daiane >>>> >>>> >>>>> >>>>> -- >>>>> Otavio Salvador O.S. Systems >>>>> http://www.ossystems.com.br http://code.ossystems.com.br >>>>> Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 >>>>> -- >>>>> _______________________________________________ >>>>> meta-freescale mailing list >>>>> [email protected] >>>>> https://lists.yoctoproject.org/listinfo/meta-freescale > -- _______________________________________________ meta-freescale mailing list [email protected] https://lists.yoctoproject.org/listinfo/meta-freescale
